Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

["Rahul Chandra" <rahul@chandra.net>]

On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> >
> > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > >
> > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > >
> > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > >
> > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > >
> > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > >
> > > > > > > > Added some cc's
> > > > > > > >
> > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > >
> > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > >
> > > > > > weird,
> > > > > > scankey -s reports
> > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > >
> > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > >
> > > > Use evtest to find the MSC code that is used.
> > >
> > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > >
> > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> >
> >
> > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> 
> Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> quirk". Should work for both -next and stable. I can write a patch and
> add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> used on the Duo. It is not ideal those three keycodes are grouped
> together, but it should be fine for now.


Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.



-- 
Rahul