Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

["Rahul Chandra" <rahul@chandra.net>]

Added some cc's 

*Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)

-- 
Rahul
On Tuesday, September 16, 2025 02:36 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:

> On Monday, August 25, 2025 07:30 EDT, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> 
> > On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:
> > 
> > > Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> > > 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> > > Since this code is emitted by other Asus devices, such as from the Z13
> > > for its ROG button, remove the extra codes before expanding the quirk.
> > > 
> > > For the Duo devices, which are the only ones that use this quirk, there
> > > should be no effect.
> > > 
> > > [...]
> > 
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-fixes branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > local branch there, which might take a while.
> > 
> > The list of commits applied:
> > [1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
> >       commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
> > [2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13
> 
> 
> Hi, with these commits on the branch the "Airplane Mode on detach/attach" bug comes back (The bug the quirk was intended to fix) . I think the Duo emits 0x5D (toggle, because it deactivates and activates on attach/detach) however I have not confirmed this. This is a regression from the previous patch and I propose that we either revert the commit or fix the keycode. I am not submitting a patch because I don't know if 5D is used for a different purpose on the ROG devices, can someone confirm?
> 
> -- 
> Rahul
> 
>