Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

Added some cc's 

*Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)

-- 
Rahul
On Tuesday, September 16, 2025 02:36 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:

> On Monday, August 25, 2025 07:30 EDT, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> 
> > On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:
> > 
> > > Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> > > 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> > > Since this code is emitted by other Asus devices, such as from the Z13
> > > for its ROG button, remove the extra codes before expanding the quirk.
> > > 
> > > For the Duo devices, which are the only ones that use this quirk, there
> > > should be no effect.
> > > 
> > > [...]
> > 
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-fixes branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > local branch there, which might take a while.
> > 
> > The list of commits applied:
> > [1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
> >       commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
> > [2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13
> 
> 
> Hi, with these commits on the branch the "Airplane Mode on detach/attach" bug comes back (The bug the quirk was intended to fix) . I think the Duo emits 0x5D (toggle, because it deactivates and activates on attach/detach) however I have not confirmed this. This is a regression from the previous patch and I propose that we either revert the commit or fix the keycode. I am not submitting a patch because I don't know if 5D is used for a different purpose on the ROG devices, can someone confirm?
> 
> -- 
> Rahul
> 
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
>
> Added some cc's
>
> *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)

I must have mistakenly thought that the important code on both devices
is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
both. Can you verify which codes are used on the Duo?

Antheas

> --
> Rahul
> On Tuesday, September 16, 2025 02:36 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
>
> > On Monday, August 25, 2025 07:30 EDT, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > > On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:
> > >
> > > > Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> > > > 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> > > > Since this code is emitted by other Asus devices, such as from the Z13
> > > > for its ROG button, remove the extra codes before expanding the quirk.
> > > >
> > > > For the Duo devices, which are the only ones that use this quirk, there
> > > > should be no effect.
> > > >
> > > > [...]
> > >
> > >
> > > Thank you for your contribution, it has been applied to my local
> > > review-ilpo-fixes branch. Note it will show up in the public
> > > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > > local branch there, which might take a while.
> > >
> > > The list of commits applied:
> > > [1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
> > >       commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
> > > [2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13
> >
> >
> > Hi, with these commits on the branch the "Airplane Mode on detach/attach" bug comes back (The bug the quirk was intended to fix) . I think the Duo emits 0x5D (toggle, because it deactivates and activates on attach/detach) however I have not confirmed this. This is a regression from the previous patch and I propose that we either revert the commit or fix the keycode. I am not submitting a patch because I don't know if 5D is used for a different purpose on the ROG devices, can someone confirm?
> >
> > --
> > Rahul
> >
> >
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 08:50, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > Added some cc's
> >
> > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
>
> I must have mistakenly thought that the important code on both devices
> is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> both. Can you verify which codes are used on the Duo?

And for which event

> Antheas
>
> > --
> > Rahul
> > On Tuesday, September 16, 2025 02:36 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> >
> > > On Monday, August 25, 2025 07:30 EDT, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> > >
> > > > On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:
> > > >
> > > > > Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> > > > > 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> > > > > Since this code is emitted by other Asus devices, such as from the Z13
> > > > > for its ROG button, remove the extra codes before expanding the quirk.
> > > > >
> > > > > For the Duo devices, which are the only ones that use this quirk, there
> > > > > should be no effect.
> > > > >
> > > > > [...]
> > > >
> > > >
> > > > Thank you for your contribution, it has been applied to my local
> > > > review-ilpo-fixes branch. Note it will show up in the public
> > > > platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> > > > local branch there, which might take a while.
> > > >
> > > > The list of commits applied:
> > > > [1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
> > > >       commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
> > > > [2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13
> > >
> > >
> > > Hi, with these commits on the branch the "Airplane Mode on detach/attach" bug comes back (The bug the quirk was intended to fix) . I think the Duo emits 0x5D (toggle, because it deactivates and activates on attach/detach) however I have not confirmed this. This is a regression from the previous patch and I propose that we either revert the commit or fix the keycode. I am not submitting a patch because I don't know if 5D is used for a different purpose on the ROG devices, can someone confirm?
> > >
> > > --
> > > Rahul
> > >
> > >
> >
> >

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > Added some cc's
> >
> > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> 
> I must have mistakenly thought that the important code on both devices
> is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> both. Can you verify which codes are used on the Duo?
> 
weird,
scankey -s reports
0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)


-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:

> On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> 
> > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > >
> > > Added some cc's
> > >
> > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > 
> > I must have mistakenly thought that the important code on both devices
> > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > both. Can you verify which codes are used on the Duo?
> > 
> weird,
> scankey -s reports
> 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)

It's for keyboard detach/retach, both attaching and re-attaching report the same code.


-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
>
> On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
>
> > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> >
> > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > >
> > > > Added some cc's
> > > >
> > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > >
> > > I must have mistakenly thought that the important code on both devices
> > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > both. Can you verify which codes are used on the Duo?
> > >
> > weird,
> > scankey -s reports
> > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
>
> It's for keyboard detach/retach, both attaching and re-attaching report the same code.

Use evtest to find the MSC code that is used.

Antheas

>
> --
> Rahul
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> >
> > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > >
> > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > >
> > > > > Added some cc's
> > > > >
> > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > >
> > > > I must have mistakenly thought that the important code on both devices
> > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > both. Can you verify which codes are used on the Duo?
> > > >
> > > weird,
> > > scankey -s reports
> > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> >
> > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> 
> Use evtest to find the MSC code that is used.

Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN) 

Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
Event: time 1758006247.925931, -------------- SYN_REPORT ------------
Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
Event: time 1758006247.925937, -------------- SYN_REPORT ------------
Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
Event: time 1758006255.123129, -------------- SYN_REPORT ------------



-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:

> On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> 
> > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > >
> > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > >
> > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > >
> > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > >
> > > > > > Added some cc's
> > > > > >
> > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > >
> > > > > I must have mistakenly thought that the important code on both devices
> > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > both. Can you verify which codes are used on the Duo?
> > > > >
> > > > weird,
> > > > scankey -s reports
> > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > >
> > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > 
> > Use evtest to find the MSC code that is used.
> 
> Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN) 
> 
> Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> Event: time 1758006255.123129, -------------- SYN_REPORT ------------


Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?



-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
>
> On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
>
> > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> >
> > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > >
> > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > >
> > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > >
> > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > >
> > > > > > > Added some cc's
> > > > > > >
> > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > >
> > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > both. Can you verify which codes are used on the Duo?
> > > > > >
> > > > > weird,
> > > > > scankey -s reports
> > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > >
> > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > >
> > > Use evtest to find the MSC code that is used.
> >
> > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> >
> > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
>
>
> Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?

Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
quirk". Should work for both -next and stable. I can write a patch and
add a ReportedBy for you. I will make sure to list 0x5E as the keycode
used on the Duo. It is not ideal those three keycodes are grouped
together, but it should be fine for now.

Antheas

>
>
> --
> Rahul
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> >
> > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > >
> > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > >
> > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > >
> > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > >
> > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > >
> > > > > > > > Added some cc's
> > > > > > > >
> > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > >
> > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > >
> > > > > > weird,
> > > > > > scankey -s reports
> > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > >
> > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > >
> > > > Use evtest to find the MSC code that is used.
> > >
> > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > >
> > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> >
> >
> > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> 
> Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> quirk". Should work for both -next and stable. I can write a patch and
> add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> used on the Duo. It is not ideal those three keycodes are grouped
> together, but it should be fine for now.


Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.



-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 09:15, Rahul Chandra <rahul@chandra.net> wrote:
>
> On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> > On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> > >
> > > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > >
> > > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > >
> > > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > >
> > > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > >
> > > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > >
> > > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > >
> > > > > > > > > Added some cc's
> > > > > > > > >
> > > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > > >
> > > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > > >
> > > > > > > weird,
> > > > > > > scankey -s reports
> > > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > > >
> > > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > > >
> > > > > Use evtest to find the MSC code that is used.
> > > >
> > > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > > >
> > > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> > >
> > >
> > > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> >
> > Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> > quirk". Should work for both -next and stable. I can write a patch and
> > add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> > used on the Duo. It is not ideal those three keycodes are grouped
> > together, but it should be fine for now.
>
>
> Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.

If you can compile your own kernel, can you check 0x5F is not used in
your device? Yeah, let's keep 0x5D for now.

>
>
> --
> Rahul
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 03:17 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 09:15, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> >
> > > On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> > > >
> > > > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > >
> > > > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > >
> > > > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > >
> > > > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > > >
> > > > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > > >
> > > > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > > >
> > > > > > > > > > Added some cc's
> > > > > > > > > >
> > > > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > > > >
> > > > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > > > >
> > > > > > > > weird,
> > > > > > > > scankey -s reports
> > > > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > > > >
> > > > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > > > >
> > > > > > Use evtest to find the MSC code that is used.
> > > > >
> > > > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > > > >
> > > > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> > > >
> > > >
> > > > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> > >
> > > Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> > > quirk". Should work for both -next and stable. I can write a patch and
> > > add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> > > used on the Duo. It is not ideal those three keycodes are grouped
> > > together, but it should be fine for now.
> >
> >
> > Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.
> 
> If you can compile your own kernel, can you check 0x5F is not used in
> your device? Yeah, let's keep 0x5D for now.


Yeah give it like 15 minutes to finish, just to be clear I am compiling a kernel with 0x5E & 0x5D ignored but with 0x5F allowed and running evtest?



-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 09:24, Rahul Chandra <rahul@chandra.net> wrote:
>
> On Tuesday, September 16, 2025 03:17 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> > On Tue, 16 Sept 2025 at 09:15, Rahul Chandra <rahul@chandra.net> wrote:
> > >
> > > On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > >
> > > > On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> > > > >
> > > > > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > >
> > > > > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > >
> > > > > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > >
> > > > > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > > > >
> > > > > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > > > >
> > > > > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > > > >
> > > > > > > > > > > Added some cc's
> > > > > > > > > > >
> > > > > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > > > > >
> > > > > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > > > > >
> > > > > > > > > weird,
> > > > > > > > > scankey -s reports
> > > > > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > > > > >
> > > > > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > > > > >
> > > > > > > Use evtest to find the MSC code that is used.
> > > > > >
> > > > > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > > > > >
> > > > > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > > > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > > > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > > > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> > > > >
> > > > >
> > > > > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> > > >
> > > > Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> > > > quirk". Should work for both -next and stable. I can write a patch and
> > > > add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> > > > used on the Duo. It is not ideal those three keycodes are grouped
> > > > together, but it should be fine for now.
> > >
> > >
> > > Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.
> >
> > If you can compile your own kernel, can you check 0x5F is not used in
> > your device? Yeah, let's keep 0x5D for now.
>
>
> Yeah give it like 15 minutes to finish, just to be clear I am compiling a kernel with 0x5E & 0x5D ignored but with 0x5F allowed and running evtest?

Allow all three, see which does what. I am finishing the patch.

Antheas

>
>
> --
> Rahul
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Tuesday, September 16, 2025 03:26 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:

> On Tue, 16 Sept 2025 at 09:24, Rahul Chandra <rahul@chandra.net> wrote:
> >
> > On Tuesday, September 16, 2025 03:17 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> >
> > > On Tue, 16 Sept 2025 at 09:15, Rahul Chandra <rahul@chandra.net> wrote:
> > > >
> > > > On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > >
> > > > > On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > >
> > > > > > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > >
> > > > > > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > >
> > > > > > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > >
> > > > > > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > > > > >
> > > > > > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > > > > >
> > > > > > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > Added some cc's
> > > > > > > > > > > >
> > > > > > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > > > > > >
> > > > > > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > > > > > >
> > > > > > > > > > weird,
> > > > > > > > > > scankey -s reports
> > > > > > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > > > > > >
> > > > > > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > > > > > >
> > > > > > > > Use evtest to find the MSC code that is used.
> > > > > > >
> > > > > > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > > > > > >
> > > > > > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > > > > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > > > > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > > > > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> > > > > >
> > > > > >
> > > > > > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> > > > >
> > > > > Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> > > > > quirk". Should work for both -next and stable. I can write a patch and
> > > > > add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> > > > > used on the Duo. It is not ideal those three keycodes are grouped
> > > > > together, but it should be fine for now.
> > > >
> > > >
> > > > Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.
> > >
> > > If you can compile your own kernel, can you check 0x5F is not used in
> > > your device? Yeah, let's keep 0x5D for now.
> >
> >
> > Yeah give it like 15 minutes to finish, just to be clear I am compiling a kernel with 0x5E & 0x5D ignored but with 0x5F allowed and running evtest?
> 
> Allow all three, see which does what. I am finishing the patch.


Just tried it, still just 5E can't get 5F or 5D to show up. 


-- 
Rahul

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

On Tue, 16 Sept 2025 at 09:37, Rahul Chandra <rahul@chandra.net> wrote:
>
> On Tuesday, September 16, 2025 03:26 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> > On Tue, 16 Sept 2025 at 09:24, Rahul Chandra <rahul@chandra.net> wrote:
> > >
> > > On Tuesday, September 16, 2025 03:17 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > >
> > > > On Tue, 16 Sept 2025 at 09:15, Rahul Chandra <rahul@chandra.net> wrote:
> > > > >
> > > > > On Tuesday, September 16, 2025 03:11 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > >
> > > > > > On Tue, 16 Sept 2025 at 09:08, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > >
> > > > > > > On Tuesday, September 16, 2025 03:06 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > > >
> > > > > > > > On Tuesday, September 16, 2025 02:57 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > > >
> > > > > > > > > On Tue, 16 Sept 2025 at 08:56, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > > >
> > > > > > > > > > On Tuesday, September 16, 2025 02:54 EDT, "Rahul Chandra" <rahul@chandra.net> wrote:
> > > > > > > > > >
> > > > > > > > > > > On Tuesday, September 16, 2025 02:50 EDT, Antheas Kapenekakis <lkml@antheas.dev> wrote:
> > > > > > > > > > >
> > > > > > > > > > > > On Tue, 16 Sept 2025 at 08:46, Rahul Chandra <rahul@chandra.net> wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > Added some cc's
> > > > > > > > > > > > >
> > > > > > > > > > > > > *Note I have a UX8406CA (the 2025 Arrowlake model, I assume it is the same on the MA)
> > > > > > > > > > > >
> > > > > > > > > > > > I must have mistakenly thought that the important code on both devices
> > > > > > > > > > > > is 0x5F. Perhaps on the duo is 0x5D instead or it emits events on
> > > > > > > > > > > > both. Can you verify which codes are used on the Duo?
> > > > > > > > > > > >
> > > > > > > > > > > weird,
> > > > > > > > > > > scankey -s reports
> > > > > > > > > > > 0xe0 0x73  0xe0 0xf3, the 0xe0 is for the extended scancode set but I'm confused on the other 2 codes. the WLAN quirk definitely worked before (I submitted the patch for it for the CA)
> > > > > > > > > >
> > > > > > > > > > It's for keyboard detach/retach, both attaching and re-attaching report the same code.
> > > > > > > > >
> > > > > > > > > Use evtest to find the MSC code that is used.
> > > > > > > >
> > > > > > > > Hmm it is sending 5E... But it is still activating and deactivating and reactivating airplane mode (WLAN)
> > > > > > > >
> > > > > > > > Event: time 1758006247.925931, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > > > Event: time 1758006247.925931, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > > > Event: time 1758006247.925931, -------------- SYN_REPORT ------------
> > > > > > > > Event: time 1758006247.925937, type 1 (EV_KEY), code 238 (KEY_WLAN), value 0
> > > > > > > > Event: time 1758006247.925937, -------------- SYN_REPORT ------------
> > > > > > > > Event: time 1758006255.123129, type 4 (EV_MSC), code 4 (MSC_SCAN), value 5e
> > > > > > > > Event: time 1758006255.123129, type 1 (EV_KEY), code 238 (KEY_WLAN), value 1
> > > > > > > > Event: time 1758006255.123129, -------------- SYN_REPORT ------------
> > > > > > >
> > > > > > >
> > > > > > > Sorry I'm dumb yes 5E is a new code forgot we had 5F currently, guess we should add 5E then, can you write up the patch or should I?
> > > > > >
> > > > > > Cleanest patch is a revert of "Remove extra keys from ignore_key_wlan
> > > > > > quirk". Should work for both -next and stable. I can write a patch and
> > > > > > add a ReportedBy for you. I will make sure to list 0x5E as the keycode
> > > > > > used on the Duo. It is not ideal those three keycodes are grouped
> > > > > > together, but it should be fine for now.
> > > > >
> > > > >
> > > > > Great sounds good thanks! What should we do about 5D? Just keep it in? I don't know what key on the board emits 5D (if any) since it doesn't have an airplane mode key.
> > > >
> > > > If you can compile your own kernel, can you check 0x5F is not used in
> > > > your device? Yeah, let's keep 0x5D for now.
> > >
> > >
> > > Yeah give it like 15 minutes to finish, just to be clear I am compiling a kernel with 0x5E & 0x5D ignored but with 0x5F allowed and running evtest?
> >
> > Allow all three, see which does what. I am finishing the patch.
>
>
> Just tried it, still just 5E can't get 5F or 5D to show up.

Great. Patch is sent. Thanks for the report.

By the way, I am getting mail errors from an icloud account, so one of
you is not receiving the whole chain.

Antheas

>
> --
> Rahul
>
>

[PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
Since this code is emitted by other Asus devices, such as from the Z13
for its ROG button, remove the extra codes before expanding the quirk.

For the Duo devices, which are the only ones that use this quirk, there
should be no effect.

Fixes: 9286dfd5735b ("platform/x86: asus-wmi: Fix spurious rfkill on UX8406MA")
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
 drivers/platform/x86/asus-nb-wmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index f84c3d03c1de..e6726be5890e 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -655,8 +655,6 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
 		if (atkbd_reports_vol_keys)
 			*code = ASUS_WMI_KEY_IGNORE;
 		break;
-	case 0x5D: /* Wireless console Toggle */
-	case 0x5E: /* Wireless console Enable */
 	case 0x5F: /* Wireless console Disable */
 		if (quirks->ignore_key_wlan)
 			*code = ASUS_WMI_KEY_IGNORE;

base-commit: 186f3edfdd41f2ae87fc40a9ccba52a3bf930994
-- 
2.50.1

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Antheas Kapenekakis]

Also cc'd Mathieu on this one. Would be good to verify my assessment
is correct. I asked two other Duo users while making the patch.

Antheas

On Fri, 8 Aug 2025 at 17:48, Antheas Kapenekakis <lkml@antheas.dev> wrote:
>
> Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> Since this code is emitted by other Asus devices, such as from the Z13
> for its ROG button, remove the extra codes before expanding the quirk.
>
> For the Duo devices, which are the only ones that use this quirk, there
> should be no effect.
>
> Fixes: 9286dfd5735b ("platform/x86: asus-wmi: Fix spurious rfkill on UX8406MA")
> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index f84c3d03c1de..e6726be5890e 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -655,8 +655,6 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
>                 if (atkbd_reports_vol_keys)
>                         *code = ASUS_WMI_KEY_IGNORE;
>                 break;
> -       case 0x5D: /* Wireless console Toggle */
> -       case 0x5E: /* Wireless console Enable */
>         case 0x5F: /* Wireless console Disable */
>                 if (quirks->ignore_key_wlan)
>                         *code = ASUS_WMI_KEY_IGNORE;
>
> base-commit: 186f3edfdd41f2ae87fc40a9ccba52a3bf930994
> --
> 2.50.1
>
>

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Ilpo Järvinen]

On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:

> Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> Since this code is emitted by other Asus devices, such as from the Z13
> for its ROG button, remove the extra codes before expanding the quirk.
> 
> For the Duo devices, which are the only ones that use this quirk, there
> should be no effect.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
      commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
[2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13
      commit: 132bfcd24925d4d4531a19b87acb8474be82a017

--
 i.

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk

[Rahul Chandra]

On Monday, August 25, 2025 07:30 EDT, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:

> On Fri, 08 Aug 2025 17:47:09 +0200, Antheas Kapenekakis wrote:
> 
> > Currently, the ignore_key_wlan quirk applies to keycodes 0x5D, 0x5E, and
> > 0x5F. However, the relevant code for the Asus Zenbook Duo is only 0x5F.
> > Since this code is emitted by other Asus devices, such as from the Z13
> > for its ROG button, remove the extra codes before expanding the quirk.
> > 
> > For the Duo devices, which are the only ones that use this quirk, there
> > should be no effect.
> > 
> > [...]
> 
> 
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.
> 
> The list of commits applied:
> [1/2] platform/x86: asus-wmi: Remove extra keys from ignore_key_wlan quirk
>       commit: cf3940ac737d05c85395f343fe33a3cfcadb47db
> [2/2] platform/x86: asus-wmi: Fix ROG button mapping, tablet mode on ASUS ROG Z13


Hi, with these commits on the branch the "Airplane Mode on detach/attach" bug comes back (The bug the quirk was intended to fix) . I think the Duo emits 0x5D (toggle, because it deactivates and activates on attach/detach) however I have not confirmed this. This is a regression from the previous patch and I propose that we either revert the commit or fix the keycode. I am not submitting a patch because I don't know if 5D is used for a different purpose on the ROG devices, can someone confirm?

-- 
Rahul