* [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP
[not found] <20100413163427.8acd04e5.sfr@canb.auug.org.au>
@ 2010-04-13 16:45 ` Randy Dunlap
2010-04-13 22:39 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-04-13 16:45 UTC (permalink / raw)
To: Stephen Rothwell, Matthew Garrett; +Cc: linux-next, LKML, platform-driver-x86
From: Randy Dunlap <randy.dunlap@oracle.com>
When EEEPC_WMI=y and INPUT_SPARSEKMAP=m, the build fails,
so make EEEPC_WMI depend on INPUT_SPARSEKMAP.
eeepc-wmi.c:(.text+0x28d1a9): undefined reference to `sparse_keymap_setup'
eeepc-wmi.c:(.text+0x28d1f9): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.text+0x28d2e0): undefined reference to `sparse_keymap_report_event'
eeepc-wmi.c:(.init.text+0x17069): undefined reference to `sparse_keymap_free'
eeepc-wmi.c:(.exit.text+0x2bae): undefined reference to `sparse_keymap_free'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20100413.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100413/drivers/platform/x86/Kconfig
@@ -388,7 +388,7 @@ config EEEPC_LAPTOP
config EEEPC_WMI
tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
depends on ACPI_WMI
- depends on INPUT
+ depends on INPUT && INPUT_SPARSEKMAP
depends on EXPERIMENTAL
---help---
Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP
2010-04-13 16:45 ` [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP Randy Dunlap
@ 2010-04-13 22:39 ` Dmitry Torokhov
2010-04-14 12:34 ` Matthew Garrett
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2010-04-13 22:39 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Matthew Garrett, linux-next, LKML,
platform-driver-x86
On Tuesday 13 April 2010 09:45:44 am Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When EEEPC_WMI=y and INPUT_SPARSEKMAP=m, the build fails,
> so make EEEPC_WMI depend on INPUT_SPARSEKMAP.
>
> eeepc-wmi.c:(.text+0x28d1a9): undefined reference to `sparse_keymap_setup'
> eeepc-wmi.c:(.text+0x28d1f9): undefined reference to `sparse_keymap_free'
> eeepc-wmi.c:(.text+0x28d2e0): undefined reference to
> `sparse_keymap_report_event' eeepc-wmi.c:(.init.text+0x17069): undefined
> reference to `sparse_keymap_free' eeepc-wmi.c:(.exit.text+0x2bae):
> undefined reference to `sparse_keymap_free'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100413.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20100413/drivers/platform/x86/Kconfig
> @@ -388,7 +388,7 @@ config EEEPC_LAPTOP
> config EEEPC_WMI
> tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
> depends on ACPI_WMI
> - depends on INPUT
> + depends on INPUT && INPUT_SPARSEKMAP
"select INPUT_SPARSEKMAP" please - users should not be concerned about
such implementation details.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP
2010-04-13 22:39 ` Dmitry Torokhov
@ 2010-04-14 12:34 ` Matthew Garrett
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2010-04-14 12:34 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML,
platform-driver-x86
I've queued up a patch for this.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-14 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100413163427.8acd04e5.sfr@canb.auug.org.au>
2010-04-13 16:45 ` [PATCH -next] eeepc-wmi: depends on INPUT_SPARSEKMAP Randy Dunlap
2010-04-13 22:39 ` Dmitry Torokhov
2010-04-14 12:34 ` Matthew Garrett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox