X86 platform drivers
 help / color / mirror / Atom feed
* [PATCH -next] eeepc-wmi: depends on BACKLIGHT_CLASS_DEVICE
       [not found] <20100507155520.75026a8b.sfr@canb.auug.org.au>
@ 2010-05-07 18:24 ` Randy Dunlap
  2010-05-07 18:26   ` Matthew Garrett
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-05-07 18:24 UTC (permalink / raw)
  To: Stephen Rothwell, Matthew Garrett; +Cc: linux-next, LKML, platform-driver-x86

From: Randy Dunlap <randy.dunlap@oracle.com>

eeepc-wmi uses backlight*() interfaces so it should depend on
BACKLIGHT_CLASS_DEVICE.

eeepc-wmi.c:(.text+0x2d7f54): undefined reference to `backlight_force_update'
eeepc-wmi.c:(.text+0x2d8012): undefined reference to `backlight_device_register'
eeepc-wmi.c:(.devinit.text+0x1c31c): undefined reference to `backlight_device_unregister'
eeepc-wmi.c:(.devexit.text+0x2f8b): undefined reference to `backlight_device_unregister'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/platform/x86/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100507.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100507/drivers/platform/x86/Kconfig
@@ -390,6 +390,7 @@ config EEEPC_WMI
 	depends on ACPI_WMI
 	depends on INPUT
 	depends on EXPERIMENTAL
+	depends on BACKLIGHT_CLASS_DEVICE
 	select INPUT_SPARSEKMAP
 	---help---
 	  Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] eeepc-wmi: depends on BACKLIGHT_CLASS_DEVICE
  2010-05-07 18:24 ` [PATCH -next] eeepc-wmi: depends on BACKLIGHT_CLASS_DEVICE Randy Dunlap
@ 2010-05-07 18:26   ` Matthew Garrett
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Garrett @ 2010-05-07 18:26 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, platform-driver-x86

On Fri, May 07, 2010 at 11:24:11AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> eeepc-wmi uses backlight*() interfaces so it should depend on
> BACKLIGHT_CLASS_DEVICE.
> 
> eeepc-wmi.c:(.text+0x2d7f54): undefined reference to `backlight_force_update'
> eeepc-wmi.c:(.text+0x2d8012): undefined reference to `backlight_device_register'
> eeepc-wmi.c:(.devinit.text+0x1c31c): undefined reference to `backlight_device_unregister'
> eeepc-wmi.c:(.devexit.text+0x2f8b): undefined reference to `backlight_device_unregister'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, applied for -next. I'll send this one for .34 as well.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-07 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100507155520.75026a8b.sfr@canb.auug.org.au>
2010-05-07 18:24 ` [PATCH -next] eeepc-wmi: depends on BACKLIGHT_CLASS_DEVICE Randy Dunlap
2010-05-07 18:26   ` Matthew Garrett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox