[PATCH -next] x86/platform: classmate-laptop depends on RFKILL

[PATCH -next] x86/platform: classmate-laptop depends on RFKILL

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

classmate-laptop uses rfkill interfaces, so it should depend on
RFKILL.  Otherwise, when CONFIG_RFKILL=m, these build errors happen:

classmate-laptop.c:(.text+0x54b4f2): undefined reference to `rfkill_unregister'
classmate-laptop.c:(.text+0x54b508): undefined reference to `rfkill_destroy'
classmate-laptop.c:(.text+0x54b71a): undefined reference to `rfkill_alloc'
classmate-laptop.c:(.text+0x54b739): undefined reference to `rfkill_register'
classmate-laptop.c:(.text+0x54b761): undefined reference to `rfkill_destroy'
classmate-laptop.c:(.text+0x54b841): undefined reference to `rfkill_set_sw_state'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc:	Daniel Oliveira Nascimento <don@syst.com.br>
Cc:	platform-driver-x86@vger.kernel.org
Cc:	Matthew Garrett <mjg@redhat.com>
---
 drivers/platform/x86/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100522.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100522/drivers/platform/x86/Kconfig
@@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL
 config ACPI_CMPC
 	tristate "CMPC Laptop Extras"
 	depends on X86 && ACPI
+	depends on RFKILL
 	select INPUT
 	select BACKLIGHT_CLASS_DEVICE
 	default n

[PATCH] classmate-laptop: depends on RFKILL or RFKILL=n

[Thadeu Lima de Souza Cascardo]

Randy Dunlap has reported that building classmate-laptop fails when
CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y. He suggested depending on
RFKILL, but, then, it will not be possible to select classmate-laptop
when RFKILL is off. There's no known problem with building and using
classmate-laptop with RFKILL off. So depend on RFKILL or RFKILL=n.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: platform-driver-x86@vger.kernel.org
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Daniel Oliveira Nascimento <don@syst.com.br>
---
 drivers/platform/x86/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3e1b8a2..fe7d670 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL
 config ACPI_CMPC
 	tristate "CMPC Laptop Extras"
 	depends on X86 && ACPI
+	depends on RFKILL || RFKILL=n
 	select INPUT
 	select BACKLIGHT_CLASS_DEVICE
 	default n
-- 
1.7.1

Re: [PATCH] classmate-laptop: depends on RFKILL or RFKILL=n

[Matthew Garrett]

Applied, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

[PATCH -next] platform/x86: msi-laptop depends on SERIO_I8042

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

msi-laptop uses i8042_*() interfaces, so it should depend on
SERIO_I8042.  E.g., when SERIO_I8042=m and MSI_LAPTOP=y:

msi-laptop.c:(.text+0x18a7fe): undefined reference to `i8042_install_filter'
msi-laptop.c:(.init.text+0xd69d): undefined reference to `i8042_remove_filter'
msi-laptop.c:(.exit.text+0x19c3): undefined reference to `i8042_remove_filter'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Lennart Poettering <mzxreary@0pointer.de>
---
 drivers/platform/x86/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100522.orig/drivers/platform/x86/Kconfig
+++ linux-next-20100522/drivers/platform/x86/Kconfig
@@ -151,6 +151,7 @@ config MSI_LAPTOP
 	depends on ACPI
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on RFKILL
+	depends on SERIO_I8042
 	---help---
 	  This is a driver for laptops built by MSI (MICRO-STAR
 	  INTERNATIONAL):

Re: [PATCH -next] platform/x86: msi-laptop depends on SERIO_I8042

[Matthew Garrett]

Applied, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org