From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Ds, Sreedhara" <sreedhara.ds@intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Alan Cox <alan@linux.intel.com>
Subject: Re: Patch [3/4] intel scu ipc
Date: Fri, 28 May 2010 14:50:21 +0100 [thread overview]
Message-ID: <20100528135021.GB25798@srcf.ucam.org> (raw)
In-Reply-To: <0AE3E14D83C76F4994657326177D1FF9042CE9F4A4@bgsmsx501.gar.corp.intel.com>
On Fri, May 28, 2010 at 02:12:35PM +0530, Ds, Sreedhara wrote:
> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);
This doesn't look right at all. fs_initcall is certainly wrong, and
you've also broken the ability to use this as a module without removing
any of the other module-specific code. Shouldn't other ipc drivers all
be depending on this one?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-05-28 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 8:42 Patch [3/4] intel scu ipc Ds, Sreedhara
2010-05-28 13:50 ` Matthew Garrett [this message]
2010-05-30 15:50 ` Ds, Sreedhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528135021.GB25798@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sreedhara.ds@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox