* Patch [3/4] intel scu ipc
@ 2010-05-28 8:42 Ds, Sreedhara
2010-05-28 13:50 ` Matthew Garrett
0 siblings, 1 reply; 3+ messages in thread
From: Ds, Sreedhara @ 2010-05-28 8:42 UTC (permalink / raw)
To: platform-driver-x86@vger.kernel.org, mjg@redhat.com,
x86@kernel.org, Alan Cox
[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]
Hello,
Please review and accept the patch
From f8d29b90e6015387451062a6a5ae1499de120ab4 Mon Sep 17 00:00:00 2001
From: Sreedhara DS <sreedhara.ds@intel.com>
Date: Fri, 28 May 2010 14:04:02 +0530
Subject: [PATCH] chnages to avoid late initialization of driver
ipc driver needs to be initialized before any other driver using ipc
modified: intel_scu_ipc.c
Signed-off-by: Sreedhara DS <sreedhara.ds@intel.com>
---
drivers/platform/x86/intel_scu_ipc.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
index ffd304a..8bb3fda 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -834,14 +834,8 @@ static int __init intel_scu_ipc_init(void)
return pci_register_driver(&ipc_driver);
}
-static void __exit intel_scu_ipc_exit(void)
-{
- pci_unregister_driver(&ipc_driver);
-}
-
MODULE_AUTHOR("Sreedhara DS <sreedhara.ds@intel.com>");
MODULE_DESCRIPTION("Intel SCU IPC driver");
MODULE_LICENSE("GPL");
-module_init(intel_scu_ipc_init);
-module_exit(intel_scu_ipc_exit);
+fs_initcall(intel_scu_ipc_init);
--
1.5.4.5
[-- Attachment #2: 0003-chnages-to-avoid-late-initialization-of-driver.patch --]
[-- Type: application/octet-stream, Size: 1133 bytes --]
From f8d29b90e6015387451062a6a5ae1499de120ab4 Mon Sep 17 00:00:00 2001
From: Sreedhara DS <sreedhara.ds@intel.com>
Date: Fri, 28 May 2010 14:04:02 +0530
Subject: [PATCH] chnages to avoid late initialization of driver
ipc driver needs to be initialized before any other driver using ipc
modified: intel_scu_ipc.c
Signed-off-by: Sreedhara DS <sreedhara.ds@intel.com>
---
drivers/platform/x86/intel_scu_ipc.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
index ffd304a..8bb3fda 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -834,14 +834,8 @@ static int __init intel_scu_ipc_init(void)
return pci_register_driver(&ipc_driver);
}
-static void __exit intel_scu_ipc_exit(void)
-{
- pci_unregister_driver(&ipc_driver);
-}
-
MODULE_AUTHOR("Sreedhara DS <sreedhara.ds@intel.com>");
MODULE_DESCRIPTION("Intel SCU IPC driver");
MODULE_LICENSE("GPL");
-module_init(intel_scu_ipc_init);
-module_exit(intel_scu_ipc_exit);
+fs_initcall(intel_scu_ipc_init);
--
1.5.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: Patch [3/4] intel scu ipc
2010-05-28 8:42 Patch [3/4] intel scu ipc Ds, Sreedhara
@ 2010-05-28 13:50 ` Matthew Garrett
2010-05-30 15:50 ` Ds, Sreedhara
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Garrett @ 2010-05-28 13:50 UTC (permalink / raw)
To: Ds, Sreedhara
Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, Alan Cox
On Fri, May 28, 2010 at 02:12:35PM +0530, Ds, Sreedhara wrote:
> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);
This doesn't look right at all. fs_initcall is certainly wrong, and
you've also broken the ability to use this as a module without removing
any of the other module-specific code. Shouldn't other ipc drivers all
be depending on this one?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: Patch [3/4] intel scu ipc
2010-05-28 13:50 ` Matthew Garrett
@ 2010-05-30 15:50 ` Ds, Sreedhara
0 siblings, 0 replies; 3+ messages in thread
From: Ds, Sreedhara @ 2010-05-30 15:50 UTC (permalink / raw)
To: Matthew Garrett
Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, Alan Cox,
Du, Alek
Hello,
It is observed scu ipc driver initialized later than other drivers which are using scu ipc interface (Ex, scu ipc driver initialized after GPIO driver). This behavior is observed after scu ipc driver moved from arch/x86/kernel to drivers/platform/x86. We will work out solution for this
--Sreedhara
-----Original Message-----
From: Matthew Garrett [mailto:mjg59@srcf.ucam.org]
Sent: Friday, May 28, 2010 7:20 PM
To: Ds, Sreedhara
Cc: platform-driver-x86@vger.kernel.org; x86@kernel.org; Alan Cox
Subject: Re: Patch [3/4] intel scu ipc
On Fri, May 28, 2010 at 02:12:35PM +0530, Ds, Sreedhara wrote:
> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);
This doesn't look right at all. fs_initcall is certainly wrong, and
you've also broken the ability to use this as a module without removing
any of the other module-specific code. Shouldn't other ipc drivers all
be depending on this one?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-30 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 8:42 Patch [3/4] intel scu ipc Ds, Sreedhara
2010-05-28 13:50 ` Matthew Garrett
2010-05-30 15:50 ` Ds, Sreedhara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox