* [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y [not found] <20100603134753.710a64b3.sfr@canb.auug.org.au> @ 2010-06-03 16:39 ` Randy Dunlap 2010-06-09 20:02 ` Thadeu Lima de Souza Cascardo 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2010-06-03 16:39 UTC (permalink / raw) To: Stephen Rothwell, platform-driver-x86, Matthew Garrett Cc: linux-next, LKML, Thadeu Lima de Souza Cascardo, Daniel Oliveira Nascimento From: Randy Dunlap <randy.dunlap@oracle.com> Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y: classmate-laptop should depend on RFKILL or RFKILL=n. classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister' classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy' classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state' classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc' classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register' classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20100603.orig/drivers/platform/x86/Kconfig +++ linux-next-20100603/drivers/platform/x86/Kconfig @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL config ACPI_CMPC tristate "CMPC Laptop Extras" depends on X86 && ACPI + depends on RFKILL || RFKILL=n select INPUT select BACKLIGHT_CLASS_DEVICE default n ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y 2010-06-03 16:39 ` [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y Randy Dunlap @ 2010-06-09 20:02 ` Thadeu Lima de Souza Cascardo 2010-06-09 20:05 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Thadeu Lima de Souza Cascardo @ 2010-06-09 20:02 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, platform-driver-x86, Matthew Garrett, linux-next, LKML, Daniel Oliveira Nascimento [-- Attachment #1: Type: text/plain, Size: 1342 bytes --] On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y: > classmate-laptop should depend on RFKILL or RFKILL=n. > > classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister' > classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy' > classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state' > classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc' > classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register' > classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > --- Randy, Since this implies a build failure, shouldn't it be sent for rc too? Best Regards, Cascardo. > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20100603.orig/drivers/platform/x86/Kconfig > +++ linux-next-20100603/drivers/platform/x86/Kconfig > @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL > config ACPI_CMPC > tristate "CMPC Laptop Extras" > depends on X86 && ACPI > + depends on RFKILL || RFKILL=n > select INPUT > select BACKLIGHT_CLASS_DEVICE > default n [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y 2010-06-09 20:02 ` Thadeu Lima de Souza Cascardo @ 2010-06-09 20:05 ` Randy Dunlap 2010-06-09 20:11 ` Matthew Garrett 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2010-06-09 20:05 UTC (permalink / raw) To: Thadeu Lima de Souza Cascardo Cc: Stephen Rothwell, platform-driver-x86, Matthew Garrett, linux-next, LKML, Daniel Oliveira Nascimento On 06/09/10 13:02, Thadeu Lima de Souza Cascardo wrote: > On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y: >> classmate-laptop should depend on RFKILL or RFKILL=n. >> >> classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister' >> classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy' >> classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state' >> classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc' >> classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register' >> classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy' >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> --- > > > Randy, > > Since this implies a build failure, shouldn't it be sent for rc too? Yes, it should. I hit the problem during a linux-next build, but it does apply to mainline as well. Thanks. >> drivers/platform/x86/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20100603.orig/drivers/platform/x86/Kconfig >> +++ linux-next-20100603/drivers/platform/x86/Kconfig >> @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL >> config ACPI_CMPC >> tristate "CMPC Laptop Extras" >> depends on X86 && ACPI >> + depends on RFKILL || RFKILL=n >> select INPUT >> select BACKLIGHT_CLASS_DEVICE >> default n -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y 2010-06-09 20:05 ` Randy Dunlap @ 2010-06-09 20:11 ` Matthew Garrett 0 siblings, 0 replies; 4+ messages in thread From: Matthew Garrett @ 2010-06-09 20:11 UTC (permalink / raw) To: Randy Dunlap Cc: Thadeu Lima de Souza Cascardo, Stephen Rothwell, platform-driver-x86, linux-next, LKML, Daniel Oliveira Nascimento On Wed, Jun 09, 2010 at 01:05:04PM -0700, Randy Dunlap wrote: > On 06/09/10 13:02, Thadeu Lima de Souza Cascardo wrote: > > Since this implies a build failure, shouldn't it be sent for rc too? > > Yes, it should. > I hit the problem during a linux-next build, but it does apply to mainline as well. > Thanks. It's been sent upstream, but Linus didn't pull. I'll see if I can find a set he's willing to take. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-09 20:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100603134753.710a64b3.sfr@canb.auug.org.au>
2010-06-03 16:39 ` [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y Randy Dunlap
2010-06-09 20:02 ` Thadeu Lima de Souza Cascardo
2010-06-09 20:05 ` Randy Dunlap
2010-06-09 20:11 ` Matthew Garrett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox