Re: linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!)

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 8 Dec 2010 09:46:04 -0800 Dmitry Torokhov wrote:

> On Wed, Dec 08, 2010 at 09:53:09AM +0000, David Woodhouse wrote:
> > On Wed, 2010-12-08 at 10:12 +0100, Corentin Chary wrote:
> > > 
> > > I don't really see how it's a recursive dependency, but maybe it's
> > > time to clean this KConfig.
> > > What is our current policy about that ?
> > > 
> > > I think we should *depends* on important subsystem (ACPI, INPUT, ...)
> > > and select obscure things so
> > > that the driver does not get lost if you don't enable the leds.
> > 
> > A better policy is: "NEVER USE SELECT".
> > 
> 
> No, this is BS. User selecting, for example, a button driver should not
> care that it is working in polling mode only and needs polled device
> library to work. As it was said before, drivers need to depend on major
> subsystems and select minors and library modules.

I dislike select, but reality is that modules do need to select/enable
library code and minor features sometimes.

OTOH, where drivers/platform/x86/Kconfig:ACPI_CMPC does "select INPUT"
to enable an entire subsystem is wrong and bad IMO.


> The fact that our Kconfig can't really provide us with the functionality
> we desire (be it because the logic is fuzzy and hard to formalize or
> some other reason) shoud not force "NO SELECT" policy, we just need to
> be careful when using it.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***