From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Corentin Chary <corentin.chary@gmail.com>,
sedat.dilek@gmail.com, Matthew Garrett <mjg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!)
Date: Wed, 8 Dec 2010 15:31:01 -0800 [thread overview]
Message-ID: <20101208233101.GA15294@core.coreip.homeip.net> (raw)
In-Reply-To: <1291849721.5992.145.camel@i7.infradead.org>
On Wed, Dec 08, 2010 at 11:08:39PM +0000, David Woodhouse wrote:
> On Wed, 2010-12-08 at 13:51 -0800, Randy Dunlap wrote:
> >
> > I dislike select, but reality is that modules do need to select/enable
> > library code and minor features sometimes.
> >
> > OTOH, where drivers/platform/x86/Kconfig:ACPI_CMPC does "select INPUT"
> > to enable an entire subsystem is wrong and bad IMO.
>
> This is just a deficiency in the tools. The correct answer is to fix the
> damn tools, not invent this silly 'select' facility which means much the
> same thing as 'depends on' but is implemented differently.
>
> As long ago as the mid-1990s, the Nemesis research OS was using a tcl
> xconfig tool based on the Linux one, but which would show you the
> dependencies for an option that was disabled, so you could enable them
> where you needed to. Rather than just hiding the option completely.
Even better tool would allow selecting the needed optios right there,
without the need of moving away from teh current option. And yet better
tool would not even ask user and enable them on its own. Hey, but we
have it! It's called "select".
Seriously, select is dangerous. I wonder if a rule like "One can only
select a symbol whose dependencies are all satisfied by the current
symbol and/or its parents and the symbols they select or depend on"
would not make select safe enough.
--
Dmitry
next prev parent reply other threads:[~2010-12-08 23:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 8:17 linux-next: Tree for December 8 (drivers/platform/x86/Kconfig:422:error: recursive dependency detected!) Sedat Dilek
2010-12-08 9:12 ` Corentin Chary
2010-12-08 9:18 ` Sedat Dilek
2010-12-08 9:20 ` Berg, Johannes
2010-12-08 9:28 ` Sedat Dilek
2010-12-08 9:51 ` Sedat Dilek
2010-12-08 9:53 ` David Woodhouse
2010-12-08 10:12 ` Sedat Dilek
2010-12-08 17:46 ` Dmitry Torokhov
2010-12-08 21:51 ` Randy Dunlap
2010-12-08 22:12 ` Dmitry Torokhov
2010-12-08 22:37 ` Thadeu Lima de Souza Cascardo
2010-12-08 23:08 ` David Woodhouse
2010-12-08 23:31 ` Dmitry Torokhov [this message]
2010-12-08 23:35 ` David Woodhouse
2010-12-08 23:49 ` Dmitry Torokhov
2010-12-08 23:58 ` Randy Dunlap
2010-12-08 23:34 ` Randy Dunlap
2010-12-08 23:41 ` David Woodhouse
2010-12-08 23:52 ` Dmitry Torokhov
2010-12-08 17:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208233101.GA15294@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox