Re: acer-wmi is unnecessarily loaded on a Lenovo Ideapad S12

[Carlos Corbacho <carlos@strangeworlds.co.uk>]

On Wednesday 29 December 2010 04:30:03 Joey Lee wrote:

[..]

> Maybe Wistron is the ODM (or OEM) to manufacture Lenovo Ideapad S12 ?
> Anyway,
> I added this Ideapad S12 to blacklist in acer-wmi driver because it must
> supported by ideapad-laptop driver.
> 
> I also added Cc. to Carlos Corbacho, need his review.

I suspect this is the same as all the Acer netbooks - they provide a dummy WMI 
interface which doesn't actually do anything. It would be nicer if there were 
a more generic way to do this, but this will do for now (I may try to play 
around with my Aspire One and see if I can figure out some way to detect the 
dummy interface, without needing to resort to DMI).

[..]

> From: Lee, Chun-Yi <jlee@novell.com>
> Date: Wed, 29 Dec 2010 00:17:23 +0800
> Subject: [PATCH] Add Lenovo Ideapad S12 to acer blacklist
> 
> The Lenovo Ideapad S12's _WDG have GUID that matches with AMW0, it causes
> acer-wmi driver auto-probe when system boot but there already have
> ideapad-laptop driver to support Ideapad serial.
> So, add Lenovo Ideapad S12 to acer blacklist to disable it.
> 
> Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>

Acked-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
> ---
>  drivers/platform/x86/acer-wmi.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c
> b/drivers/platform/x86/acer-wmi.c index 28288ad..387ac7c 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -310,6 +310,17 @@ static struct dmi_system_id __devinitdata
> acer_blacklist[] = { DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  		},
>  	},
> +	/*
> +	 * The Lenovo Ideapad S12 have GUID that matches with AMW0 - disable it.
> +	 * There already have ideapad-laptop driver to support Ideapad serial.
> +	 */
> +	{
> +		.ident = "Lenovo Ideapad S12",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "20021,2959"),
> +		},
> +	},
>  	{}
>  };