From: Ike Panhc <ike.pan@canonical.com>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Joey Lee <jlee@novell.com>,
vpivaini@cs.helsinki.fi, dwmw2@infradead.org,
mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org
Subject: Re: acer-wmi is unnecessarily loaded on a Lenovo Ideapad S12
Date: Thu, 03 Mar 2011 11:17:04 +0800 [thread overview]
Message-ID: <4D6F0830.1090905@canonical.com> (raw)
In-Reply-To: <201103022109.51600.carlos@strangeworlds.co.uk>
Hi,
Here[1] is the output of wmidump for ideapad s10-3 and s12-via and there is no
WMI device of ideapad B550 and Y530.
[1] http://pastebin.ubuntu.com/574793/
For now, ideapad-laptop handles the VPC2004 devices that can be found in most of
the ideapads (maybe all, but I can not sure). In my opinion, I do not think to
handle WMI in ideapad-laptop is reasonable unless we have an extra function on
ideapads and we can only control it with WMI driver.
On 03/03/2011 05:09 AM, Carlos Corbacho wrote:
> On Wednesday 02 Mar 2011 08:53:55 Joey Lee wrote:
>> 於 一,2011-01-03 於 20:49 +0000,Matthew Garrett 提到:
>>
>>> It looks like this GUID is present in a surprisingly wide range of
>>> devices (eg, http://pastebin.com/8BY0Dg64 from a Vaio...), which means
>>> that it's probably not a safe assumption that reading from the EC will
>>> give us reasonable results. Do the Acer drivers definitely do that,
>>> rather than there being some SMI that returns the data?
>>
>> The AMW0 in acer-wmi not just used by acer machines:
>>
>> #define AMW0_GUID1 "67C3371D-95A3-4C37-BB61-DD47B491DAAB"
>>
>> It was also included in Lenovo Ideapad S12 and Vaio machines' DSDT. For
>> Lenovo Ideapad, that will be better handle by ideapad-laptop driver.
>
> They might not be - Matthew's original question still stands. The old AMW0 was
> just a funny wrapper for direct BIOS calls - maybe we just need a different
> call here?
>
> What does Acer do - are they poking the EC directly, or is the call to AMW0
> just different for these machines?
>
>> Could we just direct add those model to the blacklist in acer-wmi
>> driver? or we direct check dmi in acer-wmi for only support Acer
>> machines that were included AMW0 in DSDT?
>
> Interesting. If we can't autodetect whether it's a dummy interface or not,
> then, we should change acer-wmi to whitelist what it does support - Acer,
> Fujistu Siemens and Medion - rather than trying to blacklist every vendor that
> crops up.
>
> -Carlos
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-03-03 3:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 4:30 acer-wmi is unnecessarily loaded on a Lenovo Ideapad S12 Joey Lee
2010-12-29 22:12 ` Ville-Pekka Vainio
2010-12-30 10:04 ` Carlos Corbacho
2011-01-03 20:49 ` Matthew Garrett
2011-03-02 8:53 ` Joey Lee
2011-03-02 21:09 ` Carlos Corbacho
2011-03-03 3:17 ` Ike Panhc [this message]
2011-03-03 6:50 ` Joey Lee
2011-03-03 7:11 ` Ike Panhc
2011-03-03 7:29 ` Joey Lee
2011-03-03 7:23 ` Joey Lee
2011-03-10 6:23 ` Ozan Çağlayan
2011-03-10 6:36 ` Joey Lee
2011-03-10 6:58 ` Ozan Çağlayan
2011-03-10 7:45 ` Joey Lee
2011-03-10 7:52 ` Ozan Çağlayan
2011-03-04 23:59 ` Matthew Garrett
2011-03-06 2:53 ` Joey Lee
-- strict thread matches above, loose matches on Subject: below --
2010-12-31 9:10 Joey Lee
2010-12-29 23:41 Joey Lee
2010-12-28 15:36 Joey Lee
2010-12-28 17:28 ` Ville-Pekka Vainio
2010-12-28 12:31 Ville-Pekka Vainio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6F0830.1090905@canonical.com \
--to=ike.pan@canonical.com \
--cc=carlos@strangeworlds.co.uk \
--cc=dwmw2@infradead.org \
--cc=jlee@novell.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vpivaini@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox