Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Mon, 7 Feb 2011 19:58:43 +0000
Matthew Garrett <mjg59@srcf.ucam.org> wrote:

> hwmon includes support for exposing the instantaneous current draw. 
> hwmon includes support for triggering events if a parameter crosses a 
> threshold. I still don't see why this isn't an hwmon driver, perhaps 
> with a small platform driver for the more estoric bits of the setup.

The hwmon maintainer says its not. Explicitly so. Been there, had that
discussion a while ago (in fact we had it as well in December if you
remember and I pointed you at the hwmon list discussion

Cc'd Guenter and quoting this time

------------------------------

Seems to be a lot of chip specific stuff. Actually, you don't define a
single hwmon ABI attribute right now. So moving it to the x86 platform
code might be a better option.

One possibility might be to move the driver to the x86 platform code,
but add/use hwmon ABI attributes as much as possible, and register those
attributes as hwmon device if CONFIG_HWMON is defined. Several other
platform specific drivers already do the same.

------------------------------

Hence trying to move it to drivers/platform/x86


Alan