From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch
Date: Tue, 8 Feb 2011 15:56:29 +0000 [thread overview]
Message-ID: <20110208155629.GA14523@srcf.ucam.org> (raw)
In-Reply-To: <20110208154916.GB13436@ericsson.com>
On Tue, Feb 08, 2011 at 07:49:16AM -0800, Guenter Roeck wrote:
> Seems to me there is some hair splitting going on here. Core element of
> hwmon drivers is that there are reported temperatures, voltages, current,
> power, humidity, etc. I don't see any of those here. All I see is various
> current limits. Those are secondary attributes from hwmon perspective.
> So I don't really see how this can be made a hwmon driver.
Ok, if the hardware has no mechanism for reporting the instantaneous
draw then I can see it not working well in an hwmon sense. But I'd
really prefer to see this look far more generic than it does - surely
other hardware has similar functionality?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-02-08 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 14:35 [PATCH RESEND] x86,mrst: Intel Medfield over-current detection patch Alan Cox
2011-02-07 19:58 ` Matthew Garrett
2011-02-08 10:45 ` Alan Cox
2011-02-08 13:52 ` Matthew Garrett
2011-02-08 14:08 ` Alan Cox
2011-02-08 15:49 ` Guenter Roeck
2011-02-08 15:56 ` Matthew Garrett [this message]
2011-02-08 16:09 ` Alan Cox
2011-02-08 16:19 ` Matthew Garrett
2011-02-08 16:21 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208155629.GA14523@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=guenter.roeck@ericsson.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox