* [PATCH -rc1] msi-laptop: fix config-dependent build error [not found] <AANLkTikwbY5mm10ZWg7B6XeSBkZXFqKcYVZfJCi2QGx_@mail.gmail.com> @ 2011-03-30 22:20 ` Randy Dunlap 2011-03-31 6:41 ` Joey Lee 2011-04-01 18:21 ` Matthew Garrett 0 siblings, 2 replies; 3+ messages in thread From: Randy Dunlap @ 2011-03-30 22:20 UTC (permalink / raw) To: Linus Torvalds, platform-driver-x86 Cc: Linux Kernel Mailing List, Matthew Garrett, Lee, Chun-Yi From: Randy Dunlap <randy.dunlap@oracle.com> The msi-laptop driver uses input_*() and sparse_keymap_*() interfaces. It should depend on the INPUT subsystem being present and select INPUT_SPARSEKMAP so that those interfaces are present. ERROR: "input_free_device" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "input_register_device" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "sparse_keymap_setup" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "input_allocate_device" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "sparse_keymap_report_event" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "input_unregister_device" [drivers/platform/x86/msi-laptop.ko] undefined! ERROR: "sparse_keymap_free" [drivers/platform/x86/msi-laptop.ko] undefined! Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Matthew Garrett <mjg@redhat.com> Cc: "Lee, Chun-Yi" <jlee@novell.com> --- drivers/platform/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- lnx-2639-rc1.orig/drivers/platform/x86/Kconfig +++ lnx-2639-rc1/drivers/platform/x86/Kconfig @@ -187,7 +187,8 @@ config MSI_LAPTOP depends on ACPI depends on BACKLIGHT_CLASS_DEVICE depends on RFKILL - depends on SERIO_I8042 + depends on INPUT && SERIO_I8042 + select INPUT_SPARSEKMAP ---help--- This is a driver for laptops built by MSI (MICRO-STAR INTERNATIONAL): ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -rc1] msi-laptop: fix config-dependent build error 2011-03-30 22:20 ` [PATCH -rc1] msi-laptop: fix config-dependent build error Randy Dunlap @ 2011-03-31 6:41 ` Joey Lee 2011-04-01 18:21 ` Matthew Garrett 1 sibling, 0 replies; 3+ messages in thread From: Joey Lee @ 2011-03-31 6:41 UTC (permalink / raw) To: randy.dunlap; +Cc: torvalds, mjg, linux-kernel, platform-driver-x86 於 三，2011-03-30 於 15:20 -0700，Randy Dunlap 提到： > From: Randy Dunlap <randy.dunlap@oracle.com> > > The msi-laptop driver uses input_*() and sparse_keymap_*() interfaces. > It should depend on the INPUT subsystem being present and select > INPUT_SPARSEKMAP so that those interfaces are present. > > ERROR: "input_free_device" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "input_register_device" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "sparse_keymap_setup" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "input_allocate_device" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "sparse_keymap_report_event" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "input_unregister_device" [drivers/platform/x86/msi-laptop.ko] undefined! > ERROR: "sparse_keymap_free" [drivers/platform/x86/msi-laptop.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > Cc: Matthew Garrett <mjg@redhat.com> > Cc: "Lee, Chun-Yi" <jlee@novell.com> > --- > drivers/platform/x86/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- lnx-2639-rc1.orig/drivers/platform/x86/Kconfig > +++ lnx-2639-rc1/drivers/platform/x86/Kconfig > @@ -187,7 +187,8 @@ config MSI_LAPTOP > depends on ACPI > depends on BACKLIGHT_CLASS_DEVICE > depends on RFKILL > - depends on SERIO_I8042 > + depends on INPUT && SERIO_I8042 > + select INPUT_SPARSEKMAP > ---help--- > This is a driver for laptops built by MSI (MICRO-STAR > INTERNATIONAL): > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thank's, it's good to me! Acked-by: "Lee, Chun-Yi" <jlee@novell.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -rc1] msi-laptop: fix config-dependent build error 2011-03-30 22:20 ` [PATCH -rc1] msi-laptop: fix config-dependent build error Randy Dunlap 2011-03-31 6:41 ` Joey Lee @ 2011-04-01 18:21 ` Matthew Garrett 1 sibling, 0 replies; 3+ messages in thread From: Matthew Garrett @ 2011-04-01 18:21 UTC (permalink / raw) To: Randy Dunlap Cc: Linus Torvalds, platform-driver-x86, Linux Kernel Mailing List, Lee, Chun-Yi Applied, thanks. -- Matthew Garrett | mjg59@srcf.ucam.org ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-01 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AANLkTikwbY5mm10ZWg7B6XeSBkZXFqKcYVZfJCi2QGx_@mail.gmail.com>
2011-03-30 22:20 ` [PATCH -rc1] msi-laptop: fix config-dependent build error Randy Dunlap
2011-03-31 6:41 ` Joey Lee
2011-04-01 18:21 ` Matthew Garrett
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox