From: Mattia Dongili <malattia@linux.it>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matthew Garrett <mjg@redhat.com>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: (sony-laptop): Remove unused variables
Date: Thu, 26 May 2011 20:48:19 +0900 [thread overview]
Message-ID: <20110526114817.GA9097@kamineko.org> (raw)
In-Reply-To: <1306392847-5993-1-git-send-email-linux@roeck-us.net>
On Wed, May 25, 2011 at 11:54:07PM -0700, Guenter Roeck wrote:
> Remove unused variable 'handle' from functions sony_nc_get_brightness_ng()
> and sony_nc_update_status_ng().
>
> This commit fixes the following build warnings:
>
> drivers/platform/x86/sony-laptop.c: In function sony_nc_get_brightness_ng:
> drivers/platform/x86/sony-laptop.c:964: warning: unused variable handle
> drivers/platform/x86/sony-laptop.c: In function sony_nc_update_status_ng:
> drivers/platform/x86/sony-laptop.c:976: warning: unused variable handle
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Mattia Dongili <malattia@linux.it>
> ---
> drivers/platform/x86/sony-laptop.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 6fe8cd6..9a2c319 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -961,7 +961,6 @@ static int sony_backlight_get_brightness(struct backlight_device *bd)
> static int sony_nc_get_brightness_ng(struct backlight_device *bd)
> {
> int result;
> - int *handle = (int *)bl_get_data(bd);
> struct sony_backlight_props *sdev =
> (struct sony_backlight_props *)bl_get_data(bd);
oh dear, thanks for catching it.
--
mattia
:wq!
prev parent reply other threads:[~2011-05-26 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 6:54 [PATCH] platform/x86: (sony-laptop): Remove unused variables Guenter Roeck
2011-05-26 11:48 ` Mattia Dongili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526114817.GA9097@kamineko.org \
--to=malattia@linux.it \
--cc=linux@roeck-us.net \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox