* [PATCH] platform/x86: (sony-laptop): Remove unused variables
@ 2011-05-26 6:54 Guenter Roeck
2011-05-26 11:48 ` Mattia Dongili
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2011-05-26 6:54 UTC (permalink / raw)
To: Mattia Dongili, Matthew Garrett; +Cc: platform-driver-x86, Guenter Roeck
Remove unused variable 'handle' from functions sony_nc_get_brightness_ng()
and sony_nc_update_status_ng().
This commit fixes the following build warnings:
drivers/platform/x86/sony-laptop.c: In function sony_nc_get_brightness_ng:
drivers/platform/x86/sony-laptop.c:964: warning: unused variable handle
drivers/platform/x86/sony-laptop.c: In function sony_nc_update_status_ng:
drivers/platform/x86/sony-laptop.c:976: warning: unused variable handle
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/platform/x86/sony-laptop.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 6fe8cd6..9a2c319 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -961,7 +961,6 @@ static int sony_backlight_get_brightness(struct backlight_device *bd)
static int sony_nc_get_brightness_ng(struct backlight_device *bd)
{
int result;
- int *handle = (int *)bl_get_data(bd);
struct sony_backlight_props *sdev =
(struct sony_backlight_props *)bl_get_data(bd);
@@ -973,7 +972,6 @@ static int sony_nc_get_brightness_ng(struct backlight_device *bd)
static int sony_nc_update_status_ng(struct backlight_device *bd)
{
int value, result;
- int *handle = (int *)bl_get_data(bd);
struct sony_backlight_props *sdev =
(struct sony_backlight_props *)bl_get_data(bd);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: (sony-laptop): Remove unused variables
2011-05-26 6:54 [PATCH] platform/x86: (sony-laptop): Remove unused variables Guenter Roeck
@ 2011-05-26 11:48 ` Mattia Dongili
0 siblings, 0 replies; 2+ messages in thread
From: Mattia Dongili @ 2011-05-26 11:48 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Matthew Garrett, platform-driver-x86
On Wed, May 25, 2011 at 11:54:07PM -0700, Guenter Roeck wrote:
> Remove unused variable 'handle' from functions sony_nc_get_brightness_ng()
> and sony_nc_update_status_ng().
>
> This commit fixes the following build warnings:
>
> drivers/platform/x86/sony-laptop.c: In function sony_nc_get_brightness_ng:
> drivers/platform/x86/sony-laptop.c:964: warning: unused variable handle
> drivers/platform/x86/sony-laptop.c: In function sony_nc_update_status_ng:
> drivers/platform/x86/sony-laptop.c:976: warning: unused variable handle
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Mattia Dongili <malattia@linux.it>
> ---
> drivers/platform/x86/sony-laptop.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index 6fe8cd6..9a2c319 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -961,7 +961,6 @@ static int sony_backlight_get_brightness(struct backlight_device *bd)
> static int sony_nc_get_brightness_ng(struct backlight_device *bd)
> {
> int result;
> - int *handle = (int *)bl_get_data(bd);
> struct sony_backlight_props *sdev =
> (struct sony_backlight_props *)bl_get_data(bd);
oh dear, thanks for catching it.
--
mattia
:wq!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-26 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 6:54 [PATCH] platform/x86: (sony-laptop): Remove unused variables Guenter Roeck
2011-05-26 11:48 ` Mattia Dongili
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox