* Re: Linux 3.2-rc1
[not found] ` <CAKWSe6Dr7G3TgeMiff=hrT1bMc+StnXdtW0MEmQcuA5yFOWJYw@mail.gmail.com>
@ 2011-11-08 20:13 ` Linus Torvalds
2011-11-08 20:15 ` Matthew Garrett
2011-11-08 20:44 ` Linus Torvalds
0 siblings, 2 replies; 3+ messages in thread
From: Linus Torvalds @ 2011-11-08 20:13 UTC (permalink / raw)
To: Alessandro Suardi, Matthew Garrett, platform-driver-x86
Cc: Linux Kernel Mailing List
On Tue, Nov 8, 2011 at 6:53 AM, Alessandro Suardi
<alessandro.suardi@gmail.com> wrote:
>
> Dell laptop support (and I'd suspect other drivers using LED support)
> doesn't build with undefined LED-related functions, as in:
>
> ERROR: "led_classdev_unregister" [drivers/platform/x86/dell-laptop.ko]
> undefined!
> ERROR: "led_classdev_register" [drivers/platform/x86/dell-laptop.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> It's enough to configure NEW_LEDS (unneeded in 3.1.0) to allow the build to go
> through; maybe NEW_LEDS should be auto-selected in Kconfig by drivers that
> make use of led_classdev_* functions ?
Yeah, that sounds like the right fix. There are a lot of "select
NEW_LEDS" around already, but apparently not the Dell driver.
Matthew?
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Linux 3.2-rc1
2011-11-08 20:13 ` Linux 3.2-rc1 Linus Torvalds
@ 2011-11-08 20:15 ` Matthew Garrett
2011-11-08 20:44 ` Linus Torvalds
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Garrett @ 2011-11-08 20:15 UTC (permalink / raw)
To: Linus Torvalds
Cc: Alessandro Suardi, platform-driver-x86, Linux Kernel Mailing List
On Tue, Nov 08, 2011 at 12:13:16PM -0800, Linus Torvalds wrote:
> On Tue, Nov 8, 2011 at 6:53 AM, Alessandro Suardi
> <alessandro.suardi@gmail.com> wrote:
> >
> > Dell laptop support (and I'd suspect other drivers using LED support)
> > doesn't build with undefined LED-related functions, as in:
> >
> > ERROR: "led_classdev_unregister" [drivers/platform/x86/dell-laptop.ko]
> > undefined!
> > ERROR: "led_classdev_register" [drivers/platform/x86/dell-laptop.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > It's enough to configure NEW_LEDS (unneeded in 3.1.0) to allow the build to go
> > through; maybe NEW_LEDS should be auto-selected in Kconfig by drivers that
> > make use of led_classdev_* functions ?
>
> Yeah, that sounds like the right fix. There are a lot of "select
> NEW_LEDS" around already, but apparently not the Dell driver.
Sorry, missed that change. Yes, that sounds completely reasonable.
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Linux 3.2-rc1
2011-11-08 20:13 ` Linux 3.2-rc1 Linus Torvalds
2011-11-08 20:15 ` Matthew Garrett
@ 2011-11-08 20:44 ` Linus Torvalds
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2011-11-08 20:44 UTC (permalink / raw)
To: Alessandro Suardi, Matthew Garrett, platform-driver-x86
Cc: Linux Kernel Mailing List
On Tue, Nov 8, 2011 at 12:13 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Yeah, that sounds like the right fix. There are a lot of "select
> NEW_LEDS" around already, but apparently not the Dell driver.
Hmm. Interesting. Selecting NEW_LEDS (and LEDS_CLASS) leads to some
insane Kconfig warnings. Will have to take a look at what makes that
Dell driver different from the other laptop drivers that do the same..
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-08 20:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CA+55aFzytqbGcOzWvYAo-EnJCeK5mFqdCF5OjMTeM5UBfeyCXw@mail.gmail.com>
[not found] ` <CAKWSe6Dr7G3TgeMiff=hrT1bMc+StnXdtW0MEmQcuA5yFOWJYw@mail.gmail.com>
2011-11-08 20:13 ` Linux 3.2-rc1 Linus Torvalds
2011-11-08 20:15 ` Matthew Garrett
2011-11-08 20:44 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox