* [patch] samsung-laptop: cleanup return type: mode_t vs umode_t
@ 2012-03-15 7:10 Dan Carpenter
2012-03-15 8:14 ` Corentin Chary
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-03-15 7:10 UTC (permalink / raw)
To: Corentin Chary; +Cc: Matthew Garrett, platform-driver-x86, kernel-janitors
This function returns a umode_t (unsigned short) instead of mode_t which
is an unsigned int on some architectures. Cleaning this up silences a
compile warning:
drivers/platform/x86/samsung-laptop.c:1108:2: warning: initialization
from incompatible pointer type [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 7d7109f..0550bc5 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1086,7 +1086,7 @@ static int __init samsung_backlight_init(struct samsung_laptop *samsung)
return 0;
}
-static mode_t samsung_sysfs_is_visible(struct kobject *kobj,
+static umode_t samsung_sysfs_is_visible(struct kobject *kobj,
struct attribute *attr, int idx)
{
struct device *dev = container_of(kobj, struct device, kobj);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] samsung-laptop: cleanup return type: mode_t vs umode_t
2012-03-15 7:10 [patch] samsung-laptop: cleanup return type: mode_t vs umode_t Dan Carpenter
@ 2012-03-15 8:14 ` Corentin Chary
0 siblings, 0 replies; 2+ messages in thread
From: Corentin Chary @ 2012-03-15 8:14 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Matthew Garrett, platform-driver-x86, kernel-janitors
On Thu, Mar 15, 2012 at 8:10 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This function returns a umode_t (unsigned short) instead of mode_t which
> is an unsigned int on some architectures. Cleaning this up silences a
> compile warning:
>
> drivers/platform/x86/samsung-laptop.c:1108:2: warning: initialization
> from incompatible pointer type [enabled by default]
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index 7d7109f..0550bc5 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -1086,7 +1086,7 @@ static int __init samsung_backlight_init(struct samsung_laptop *samsung)
> return 0;
> }
>
> -static mode_t samsung_sysfs_is_visible(struct kobject *kobj,
> +static umode_t samsung_sysfs_is_visible(struct kobject *kobj,
> struct attribute *attr, int idx)
> {
> struct device *dev = container_of(kobj, struct device, kobj);
Thanks for the patch.
Acked-by: Corentin Chary <corentincj@iksaif.net>
Matthew, could you grab that one too ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-15 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-15 7:10 [patch] samsung-laptop: cleanup return type: mode_t vs umode_t Dan Carpenter
2012-03-15 8:14 ` Corentin Chary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox