[patch] wmi: parse_wdg() should return kernel error codes

[patch] wmi: parse_wdg() should return kernel error codes

[Dan Carpenter]

The current code returns a mix of acpi_status and kernel error codes.
It should just return kernel error codes.  There are already error paths
in this function which return -ENOMEM and that's what the caller
expects.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index b13344c..f75ea69 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -778,7 +778,7 @@ static bool guid_already_parsed(const char *guid_string)
 /*
  * Parse the _WDG method for the GUID data blocks
  */
-static acpi_status parse_wdg(acpi_handle handle)
+static int parse_wdg(acpi_handle handle)
 {
 	struct acpi_buffer out = {ACPI_ALLOCATE_BUFFER, NULL};
 	union acpi_object *obj;
@@ -810,7 +810,7 @@ static acpi_status parse_wdg(acpi_handle handle)
 
 		wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL);
 		if (!wblock)
-			return AE_NO_MEMORY;
+			return -ENOMEM;
 
 		wblock->handle = handle;
 		wblock->gblock = gblock[i];

Re: [patch] wmi: parse_wdg() should return kernel error codes

[Matthew Garrett]

On Wed, 2013-08-14 at 12:02 +0300, Dan Carpenter wrote:
> The current code returns a mix of acpi_status and kernel error codes.
> It should just return kernel error codes.  There are already error
> paths
> in this function which return -ENOMEM and that's what the caller
> expects.

Applied, thanks.

-- 
Matthew Garrett <matthew.garrett@nebula.com>