X86 platform drivers
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: mario_limonciello@dell.com
Cc: platform-driver-x86@vger.kernel.org
Subject: re: Add WMI driver for controlling AlienFX features on some Alienware products
Date: Wed, 9 Apr 2014 18:20:01 +0300	[thread overview]
Message-ID: <20140409152001.GA24536@mwanda> (raw)

Hello Mario Limonciello,

This is a semi-automatic email about new static checker warnings.

The patch d17a5ee12973: "Add WMI driver for controlling AlienFX
features on some Alienware products" from Apr 4, 2014, leads to the
following Smatch complaint:

drivers/platform/x86/alienware-wmi.c:551 alienware_wmi_exit()
	 warn: variable dereferenced before check 'platform_device' (see line 549)

drivers/platform/x86/alienware-wmi.c
   548	{
   549		alienware_zone_exit(platform_device);
                                    ^^^^^^^^^^^^^^^
   550		remove_hdmi(platform_device);
                            ^^^^^^^^^^^^^^^
   551		if (platform_device) {
                    ^^^^^^^^^^^^^^^
   552			platform_device_unregister(platform_device);
   553			platform_driver_unregister(&platform_driver);

regards,
dan carpenter

             reply	other threads:[~2014-04-09 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 15:20 Dan Carpenter [this message]
2014-04-09 15:50 ` Add WMI driver for controlling AlienFX features on some Alienware products Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409152001.GA24536@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=mario_limonciello@dell.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox