X86 platform drivers
 help / color / mirror / Atom feed
From: Mario Limonciello <mario_limonciello@dell.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Subject: Re: Add WMI driver for controlling AlienFX features on some Alienware products
Date: Wed, 09 Apr 2014 10:50:49 -0500	[thread overview]
Message-ID: <53456C59.9080300@dell.com> (raw)
In-Reply-To: <20140409152001.GA24536@mwanda>


On 04/09/2014 10:20 AM, Dan Carpenter wrote:
> Hello Mario Limonciello,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch d17a5ee12973: "Add WMI driver for controlling AlienFX
> features on some Alienware products" from Apr 4, 2014, leads to the
> following Smatch complaint:
>
> drivers/platform/x86/alienware-wmi.c:551 alienware_wmi_exit()
> 	 warn: variable dereferenced before check 'platform_device' (see line 549)
>
> drivers/platform/x86/alienware-wmi.c
>     548	{
>     549		alienware_zone_exit(platform_device);
>                                      ^^^^^^^^^^^^^^^
>     550		remove_hdmi(platform_device);
>                              ^^^^^^^^^^^^^^^
>     551		if (platform_device) {
>                      ^^^^^^^^^^^^^^^
>     552			platform_device_unregister(platform_device);
>     553			platform_driver_unregister(&platform_driver);
>
> regards,
> dan carpenter
Hi Dan,

Thanks for letting me know.  I did submit a follow up patch for this behavior here a few days ago:

http://www.spinics.net/lists/platform-driver-x86/msg05233.html

Thanks,

      reply	other threads:[~2014-04-09 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 15:20 Add WMI driver for controlling AlienFX features on some Alienware products Dan Carpenter
2014-04-09 15:50 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53456C59.9080300@dell.com \
    --to=mario_limonciello@dell.com \
    --cc=dan.carpenter@oracle.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox