X86 platform drivers
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Ismael Luceno <ismael.luceno@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
	Cezary Jackiewicz <cezary.jackiewicz@gmail.com>
Subject: Re: [PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver
Date: Tue, 20 May 2014 16:25:11 +0100	[thread overview]
Message-ID: <20140520162511.54aad852@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1400434571-17644-1-git-send-email-ismael.luceno@gmail.com>

>  config COMPAL_LAPTOP
> -	tristate "Compal Laptop Extras"
> +	tristate "Compal (and Dell) Laptop Extras"

Compal make laptops for lots of companies (second only to Quanta). In
some cases they make complete "product" and companies slap their logo on,
in other cases they make laptops for companies. So it's not just Dell but
includes some Toshiba and many other makes.

Equally I think it's fair to say that most people configuring their
kernel are not going to know if their laptop is a rebadged Compal or
something with the same interfaces so adding more info as you are doing
is a good thing. Perhaps however it should be Compal (and some other) ?

The list btw wouldalso include things like the Dell Vostro 1200 (which
is a Compal JFT00 I believe). The big problem is that it's really a
*huge* list of devices from many vendors. The text might even be closer
to "if in doubt try.."

dmidecode | grep -i compal can be informative. What does it say for the
Dell mini's you have ?

Alan

  reply	other threads:[~2014-05-20 15:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-18 17:36 [PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver Ismael Luceno
2014-05-20 15:25 ` One Thousand Gnomes [this message]
2014-05-21 19:56   ` Ismael Luceno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140520162511.54aad852@alan.etchedpixels.co.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=ismael.luceno@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox