[PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver

[PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver

[Ismael Luceno]

Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
 drivers/platform/x86/Kconfig | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 27df2c5..4dbe1e4 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -102,7 +102,7 @@ config DELL_LAPTOP
 	default n
 	---help---
 	This driver adds support for rfkill and backlight control to Dell
-	laptops.
+	laptops (except for some models covered by the Compal driver).
 
 config DELL_WMI
 	tristate "Dell WMI extras"
@@ -265,7 +265,7 @@ config PANASONIC_LAPTOP
 	  R2, R3, R5, T2, W2 and Y2 series), say Y.
 
 config COMPAL_LAPTOP
-	tristate "Compal Laptop Extras"
+	tristate "Compal (and Dell) Laptop Extras"
 	depends on ACPI
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on RFKILL
@@ -279,9 +279,19 @@ config COMPAL_LAPTOP
 	  Compal FL92/JFL92
 	  Compal FT00/IFT00
 
-	  It adds support for Bluetooth, WLAN and LCD brightness control.
+	  And following laptops by Dell:
+
+	  Dell Mini 9 (Inspiron 910)
+	  Dell Mini 10 (Inspiron 1010)
+	  Dell Mini 10v (Inspiron 1011)
+	  Dell Mini 1012 (Inspiron 1012)
+	  Dell Inspiron 11z (Inspiron 1110)
+	  Dell Mini 12 (Inspiron 1210)
+
+	  It adds support for rfkill, Bluetooth, WLAN and LCD brightness
+	  control.
 
-	  If you have an Compal FL9x/IFL9x/FT00 laptop, say Y or M here.
+	  If you have any of the aforementioned models, say Y or M here.
 
 config SONY_LAPTOP
 	tristate "Sony Laptop Extras"
-- 
1.9.1

Re: [PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver

[One Thousand Gnomes]

>  config COMPAL_LAPTOP
> -	tristate "Compal Laptop Extras"
> +	tristate "Compal (and Dell) Laptop Extras"

Compal make laptops for lots of companies (second only to Quanta). In
some cases they make complete "product" and companies slap their logo on,
in other cases they make laptops for companies. So it's not just Dell but
includes some Toshiba and many other makes.

Equally I think it's fair to say that most people configuring their
kernel are not going to know if their laptop is a rebadged Compal or
something with the same interfaces so adding more info as you are doing
is a good thing. Perhaps however it should be Compal (and some other) ?

The list btw wouldalso include things like the Dell Vostro 1200 (which
is a Compal JFT00 I believe). The big problem is that it's really a
*huge* list of devices from many vendors. The text might even be closer
to "if in doubt try.."

dmidecode | grep -i compal can be informative. What does it say for the
Dell mini's you have ?

Alan

Re: [PATCH] platform: x86: Kconfig: Mention Dell models supported by the Compal driver

[Ismael Luceno]

On Tue, 20 May 2014 16:25:11 +0100
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> wrote:
> >  config COMPAL_LAPTOP
> > -	tristate "Compal Laptop Extras"
> > +	tristate "Compal (and Dell) Laptop Extras"
> 
<...>
> The list btw wouldalso include things like the Dell Vostro 1200 (which
> is a Compal JFT00 I believe). The big problem is that it's really a
> *huge* list of devices from many vendors. The text might even be
> closer to "if in doubt try.."

Thanks for pointing out the issue; putting the list on Kconfig doesn't
make sense, perhaps I should refer to a file under Documentation/...

> 
> dmidecode | grep -i compal can be informative. What does it say for
> the Dell mini's you have ?

Nothing at all :(. It doesn't seem like a reliable way to tell them
apart.