[PATCH] thinkpad_acpi: Fix warning

[PATCH] thinkpad_acpi: Fix warning

[Jean Delvare]

Fix the following warning:

warning: "static" is not at beginning of declaration
 void static hotkey_mask_warn_incomplete_mask(void)
 ^

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>
Cc: Darren Hart <dvhart@infradead.org>
---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-4.1-rc0.orig/drivers/platform/x86/thinkpad_acpi.c	2015-04-26 22:49:27.587460658 +0200
+++ linux-4.1-rc0/drivers/platform/x86/thinkpad_acpi.c	2015-04-27 09:39:10.628031136 +0200
@@ -2093,7 +2093,7 @@ static int hotkey_mask_get(void)
 	return 0;
 }
 
-void static hotkey_mask_warn_incomplete_mask(void)
+static void hotkey_mask_warn_incomplete_mask(void)
 {
 	/* log only what the user can fix... */
 	const u32 wantedmask = hotkey_driver_mask &


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] thinkpad_acpi: Fix warning

[Henrique de Moraes Holschuh]

On Mon, Apr 27, 2015, at 04:45, Jean Delvare wrote:
> Fix the following warning:
> 
> warning: "static" is not at beginning of declaration
>  void static hotkey_mask_warn_incomplete_mask(void)
>  ^
> 
> Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> Cc: Henrique de Moraes Holschuh <ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
> Cc: Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

Acked-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>

> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-4.1-rc0.orig/drivers/platform/x86/thinkpad_acpi.c	2015-04-26 22:49:27.587460658 +0200
> +++ linux-4.1-rc0/drivers/platform/x86/thinkpad_acpi.c	2015-04-27 09:39:10.628031136 +0200
> @@ -2093,7 +2093,7 @@ static int hotkey_mask_get(void)
>  	return 0;
>  }
>  
> -void static hotkey_mask_warn_incomplete_mask(void)
> +static void hotkey_mask_warn_incomplete_mask(void)
>  {
>  	/* log only what the user can fix... */
>  	const u32 wantedmask = hotkey_driver_mask &
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support


-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y

Re: [PATCH] thinkpad_acpi: Fix warning

[Darren Hart]

On Mon, Apr 27, 2015 at 08:55:50AM -0300, Henrique de Moraes Holschuh wrote:
> On Mon, Apr 27, 2015, at 04:45, Jean Delvare wrote:
> > Fix the following warning:
> > 
> > warning: "static" is not at beginning of declaration
> >  void static hotkey_mask_warn_incomplete_mask(void)
> >  ^
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>
> > Cc: Darren Hart <dvhart@infradead.org>
> 
> Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

Queued, thank you.

-- 
Darren Hart
Intel Open Source Technology Center