* [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol
@ 2017-01-18 8:13 Benjamin Tissoires
2017-01-18 19:01 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tissoires @ 2017-01-18 8:13 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko, Dan Carpenter
Cc: platform-driver-x86, linux-kernel
The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform
device for controlling LID" from Nov 25, 2016, leads to the following
static checker warning:
drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device()
error: uninitialized symbol 'ts_adev'.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Dan,
Sorry for the lag in treating this simple defect.
Cheers,
Benjamin
drivers/platform/x86/surface3-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c
index cbf4d83..676cfca 100644
--- a/drivers/platform/x86/surface3-wmi.c
+++ b/drivers/platform/x86/surface3-wmi.c
@@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle,
static int s3_wmi_check_platform_device(struct device *dev, void *data)
{
- struct acpi_device *adev, *ts_adev;
+ struct acpi_device *adev, *ts_adev = NULL;
acpi_handle handle;
acpi_status status;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol
2017-01-18 8:13 [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol Benjamin Tissoires
@ 2017-01-18 19:01 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-01-18 19:01 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Darren Hart, Andy Shevchenko, Dan Carpenter, Platform Driver,
linux-kernel@vger.kernel.org
On Wed, Jan 18, 2017 at 10:13 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform
> device for controlling LID" from Nov 25, 2016, leads to the following
> static checker warning:
>
> drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device()
> error: uninitialized symbol 'ts_adev'.
>
Pushed to fixes, thanks!
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi Dan,
>
> Sorry for the lag in treating this simple defect.
>
> Cheers,
> Benjamin
>
> drivers/platform/x86/surface3-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c
> index cbf4d83..676cfca 100644
> --- a/drivers/platform/x86/surface3-wmi.c
> +++ b/drivers/platform/x86/surface3-wmi.c
> @@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle,
>
> static int s3_wmi_check_platform_device(struct device *dev, void *data)
> {
> - struct acpi_device *adev, *ts_adev;
> + struct acpi_device *adev, *ts_adev = NULL;
> acpi_handle handle;
> acpi_status status;
>
> --
> 2.9.3
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-18 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 8:13 [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol Benjamin Tissoires
2017-01-18 19:01 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox