Re: [PATCH]: dell-wmi: Found location of 'auto brightness' key in dmi table

Re: [PATCH]: dell-wmi: Found location of 'auto brightness' key in dmi table

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 2049 bytes --]

On Wednesday 18 January 2017 20:06:11 Henk wrote:
> No need for user space application, this is handled by dell-wmi.c
> itself and the key is translated into a regular linux key-code like
> the keys for brightness up/down.
> 
> For the latter these are already translated to:
> #define KEY_BRIGHTNESSDOWN      224
> #define KEY_BRIGHTNESSUP        225
> 
> Now with this patch adds support for:
> #define KEY_BRIGHTNESS_AUTO 244
> 
> See the enclosed picture for actual key

So... this key enable/disable automatic display brightness based on 
integrated ALS sensors. From your description "Found location of 'auto 
brightness'" I did not understand what exactly you mean... As I know 
these Dell keyboards, picture helped me :-) I would suggest to describe 
your change more preciously but patch is OK for me.

> 2017-01-18 19:33 GMT+01:00 Pali Rohár <pali.rohar@gmail.com>:
> > On Wednesday 18 January 2017 19:27:00 you wrote:
> > > Tested on Dell Lattitude E6500.
> > > 
> > > Signed-off-by: Henk Vergonet <henk.vergonet@gmail.com>
> > > 
> > > diff --git a/drivers/platform/x86/dell-wmi.c
> > > b/drivers/platform/x86/dell-wmi.c
> > > index 75e6370..2949aee 100644
> > > --- a/drivers/platform/x86/dell-wmi.c
> > > +++ b/drivers/platform/x86/dell-wmi.c
> > > @@ -229,7 +229,7 @@ static const u16 bios_to_linux_keycode[256]
> > > __initconst = {
> > > 
> > >      [18]    = KEY_PROG1,
> > >      [19]    = KEY_BRIGHTNESSDOWN,
> > >      [20]    = KEY_BRIGHTNESSUP,
> > > 
> > > -    [21]    = KEY_UNKNOWN,
> > > +    [21]    = KEY_BRIGHTNESS_AUTO,
> > > 
> > >      [22]    = KEY_KBDILLUMTOGGLE,
> > >      [23]    = KEY_UNKNOWN,
> > >      [24]    = KEY_SWITCHVIDEOMODE,
> > 
> > Hi! Can you describe more details? Is that key handled by
> > notebook's firmware itself or do you need some userspace
> > application for handling?
> > 
> > And what should that key suppose to do on your notebook?
> > 
> > --
> > Pali Rohár
> > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]