* [PATCH] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
@ 2017-03-08 12:22 Arvind Yadav
2017-03-08 12:54 ` Pali Rohár
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-03-08 12:22 UTC (permalink / raw)
To: mjg59, pali.rohar, dvhart, andy; +Cc: platform-driver-x86, linux-kernel
Here, dell_get_intensity can return an error. So we can assgine
props.brightness as max_brightness.
This change is done using Coccinelle.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f57dd28..0891de3 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -2053,6 +2053,9 @@ static int __init dell_init(void)
dell_backlight_device->props.brightness =
dell_get_intensity(dell_backlight_device);
+ if (dell_backlight_device->props.brightness < 0) {
+ dell_backlight_device->props.brightness = props.max_brightness;
+ }
backlight_update_status(dell_backlight_device);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
2017-03-08 12:22 [PATCH] platform/x86: dell-laptop: Handle return error form dell_get_intensity Arvind Yadav
@ 2017-03-08 12:54 ` Pali Rohár
2017-03-09 5:43 ` Arvind Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Pali Rohár @ 2017-03-08 12:54 UTC (permalink / raw)
To: Arvind Yadav; +Cc: mjg59, dvhart, andy, platform-driver-x86, linux-kernel
Hi!
On Wednesday 08 March 2017 17:52:27 Arvind Yadav wrote:
> Here, dell_get_intensity can return an error.
Right. That is truth and we should check for errors.
> So we can assgine props.brightness as max_brightness.
But why to max_brightness? Seems that this is incorrect handling of
error too...
> This change is done using Coccinelle.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/platform/x86/dell-laptop.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f57dd28..0891de3 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -2053,6 +2053,9 @@ static int __init dell_init(void)
>
> dell_backlight_device->props.brightness =
> dell_get_intensity(dell_backlight_device);
> + if (dell_backlight_device->props.brightness < 0) {
> + dell_backlight_device->props.brightness = props.max_brightness;
> + }
> backlight_update_status(dell_backlight_device);
> }
>
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Handle return error form dell_get_intensity.
2017-03-08 12:54 ` Pali Rohár
@ 2017-03-09 5:43 ` Arvind Yadav
0 siblings, 0 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-03-09 5:43 UTC (permalink / raw)
To: Pali Rohár; +Cc: mjg59, dvhart, andy, platform-driver-x86, linux-kernel
Hi,
Yes, you are right. I will handle return error correctly.
Thanks
-Arvind
On Wednesday 08 March 2017 06:24 PM, Pali Rohár wrote:
> Hi!
>
> On Wednesday 08 March 2017 17:52:27 Arvind Yadav wrote:
>> Here, dell_get_intensity can return an error.
> Right. That is truth and we should check for errors.
>
>> So we can assgine props.brightness as max_brightness.
> But why to max_brightness? Seems that this is incorrect handling of
> error too...
>
>> This change is done using Coccinelle.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/platform/x86/dell-laptop.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
>> index f57dd28..0891de3 100644
>> --- a/drivers/platform/x86/dell-laptop.c
>> +++ b/drivers/platform/x86/dell-laptop.c
>> @@ -2053,6 +2053,9 @@ static int __init dell_init(void)
>>
>> dell_backlight_device->props.brightness =
>> dell_get_intensity(dell_backlight_device);
>> + if (dell_backlight_device->props.brightness < 0) {
>> + dell_backlight_device->props.brightness = props.max_brightness;
>> + }
>> backlight_update_status(dell_backlight_device);
>> }
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-09 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08 12:22 [PATCH] platform/x86: dell-laptop: Handle return error form dell_get_intensity Arvind Yadav
2017-03-08 12:54 ` Pali Rohár
2017-03-09 5:43 ` Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox