* [PATCH v2 1/2] platform: x86: silead_dmi: Constify properties arrays
@ 2017-03-22 15:55 Hans de Goede
2017-03-22 15:55 ` [PATCH v2 2/2] platform: x86: silead_dmi: Add entry for Insyde 7W tablets Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2017-03-22 15:55 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko
Cc: Hans de Goede, russianneuromancer, platform-driver-x86
Now that device_add_properties takes a const property_entry * rather
then a non-const one we can constify the properties arrays.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-This is a new patch in v3 of this patch-set
---
drivers/platform/x86/silead_dmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
index 02e11fd..c3909d2 100644
--- a/drivers/platform/x86/silead_dmi.c
+++ b/drivers/platform/x86/silead_dmi.c
@@ -22,10 +22,10 @@
struct silead_ts_dmi_data {
const char *acpi_name;
- struct property_entry *properties;
+ const struct property_entry *properties;
};
-static struct property_entry cube_iwork8_air_props[] = {
+static const struct property_entry cube_iwork8_air_props[] = {
PROPERTY_ENTRY_U32("touchscreen-size-x", 1660),
PROPERTY_ENTRY_U32("touchscreen-size-y", 900),
PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
@@ -39,7 +39,7 @@ static const struct silead_ts_dmi_data cube_iwork8_air_data = {
.properties = cube_iwork8_air_props,
};
-static struct property_entry jumper_ezpad_mini3_props[] = {
+static const struct property_entry jumper_ezpad_mini3_props[] = {
PROPERTY_ENTRY_U32("touchscreen-size-x", 1700),
PROPERTY_ENTRY_U32("touchscreen-size-y", 1150),
PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] platform: x86: silead_dmi: Add entry for Insyde 7W tablets
2017-03-22 15:55 [PATCH v2 1/2] platform: x86: silead_dmi: Constify properties arrays Hans de Goede
@ 2017-03-22 15:55 ` Hans de Goede
2017-03-22 17:33 ` Darren Hart
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2017-03-22 15:55 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko
Cc: Hans de Goede, russianneuromancer, platform-driver-x86
Add an entry providing the necessary info to make the touchscreen work
on various tablets based on the Insyde 7W whitebox tablet.
This has been tested on a DEXP Ursus 7W tablet.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
-constify the added properties array
---
drivers/platform/x86/silead_dmi.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c
index c3909d2..26b388d 100644
--- a/drivers/platform/x86/silead_dmi.c
+++ b/drivers/platform/x86/silead_dmi.c
@@ -53,6 +53,19 @@ static const struct silead_ts_dmi_data jumper_ezpad_mini3_data = {
.properties = jumper_ezpad_mini3_props,
};
+static const struct property_entry dexp_ursus_7w_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 890),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 630),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1686-dexp-ursus-7w.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ { }
+};
+
+static const struct silead_ts_dmi_data dexp_ursus_7w_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = dexp_ursus_7w_props,
+};
+
static const struct dmi_system_id silead_ts_dmi_table[] = {
{
/* CUBE iwork8 Air */
@@ -72,6 +85,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
DMI_MATCH(DMI_BIOS_VERSION, "jumperx.T87.KFBNEEA"),
},
},
+ {
+ /* DEXP Ursus 7W */
+ .driver_data = (void *)&dexp_ursus_7w_data,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "7W"),
+ },
+ },
{ },
};
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] platform: x86: silead_dmi: Add entry for Insyde 7W tablets
2017-03-22 15:55 ` [PATCH v2 2/2] platform: x86: silead_dmi: Add entry for Insyde 7W tablets Hans de Goede
@ 2017-03-22 17:33 ` Darren Hart
0 siblings, 0 replies; 3+ messages in thread
From: Darren Hart @ 2017-03-22 17:33 UTC (permalink / raw)
To: Hans de Goede; +Cc: Andy Shevchenko, russianneuromancer, platform-driver-x86
On Wed, Mar 22, 2017 at 04:55:54PM +0100, Hans de Goede wrote:
> Add an entry providing the necessary info to make the touchscreen work
> on various tablets based on the Insyde 7W whitebox tablet.
>
> This has been tested on a DEXP Ursus 7W tablet.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Queued to testing, thanks Hans.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-22 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-22 15:55 [PATCH v2 1/2] platform: x86: silead_dmi: Constify properties arrays Hans de Goede
2017-03-22 15:55 ` [PATCH v2 2/2] platform: x86: silead_dmi: Add entry for Insyde 7W tablets Hans de Goede
2017-03-22 17:33 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox