From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Shih-Yuan Lee (FourDollars)" <sylee@canonical.com>
Cc: platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH] platform/x86: dell-wmi: Add an event created by Dell Latitude 5495
Date: Tue, 19 Dec 2017 09:34:55 +0100 [thread overview]
Message-ID: <20171219083455.zekue2qqrf46rps6@pali> (raw)
In-Reply-To: <1513654714-32175-1-git-send-email-sylee@canonical.com>
On Tuesday 19 December 2017 11:38:34 Shih-Yuan Lee (FourDollars) wrote:
> The Dell Latitude 5495 has the mic mute key.
>
> Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
> ---
> drivers/platform/x86/dell-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index fb25b20..d40f803 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -261,6 +261,9 @@ static const u16 bios_to_linux_keycode[256] = {
> * override them.
> */
> static const struct key_entry dell_wmi_keymap_type_0010[] = {
> + /* Mic mute */
> + { KE_KEY, 0x150, { KEY_F20 } },
Hi! Are you sure that this key code needs to be in 0010 table? Because
primary this table is constructed from DMI information. See
array bios_to_linux_keycode[].
> +
> /* Fn-lock */
> { KE_IGNORE, 0x151, { KEY_RESERVED } },
>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-12-19 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 3:38 [PATCH] platform/x86: dell-wmi: Add an event created by Dell Latitude 5495 Shih-Yuan Lee (FourDollars)
2017-12-19 8:34 ` Pali Rohár [this message]
[not found] ` <CAApEhgh1XfzeoWL6JQN-oOn9yGvJWB74jdfFKtL==UEyhNQs7Q@mail.gmail.com>
2017-12-19 8:41 ` Pali Rohár
2017-12-19 8:45 ` Shih-Yuan Lee (FourDollars)
2017-12-19 9:00 ` Pali Rohár
2017-12-19 9:02 ` Shih-Yuan Lee (FourDollars)
2017-12-19 9:06 ` Pali Rohár
2017-12-19 9:06 ` Pali Rohár
2017-12-19 9:17 ` Shih-Yuan Lee (FourDollars)
2017-12-19 9:33 ` Pali Rohár
2017-12-19 9:38 ` Shih-Yuan Lee (FourDollars)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219083455.zekue2qqrf46rps6@pali \
--to=pali.rohar@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sylee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox