Re: [PATCH] platform/x86: dell-wmi: Add an event created by Dell Latitude 5495

["Pali Rohár" <pali.rohar@gmail.com>]

On Tuesday 19 December 2017 17:02:52 Shih-Yuan Lee (FourDollars) wrote:
> On Tue, Dec 19, 2017 at 5:00 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > On Tuesday 19 December 2017 16:45:44 Shih-Yuan Lee (FourDollars) wrote:
> >> On Tue, Dec 19, 2017 at 4:41 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >> > On Tuesday 19 December 2017 16:38:32 Shih-Yuan Lee (FourDollars) wrote:
> >> >> On Tue, Dec 19, 2017 at 4:34 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >> >>
> >> >> > On Tuesday 19 December 2017 11:38:34 Shih-Yuan Lee (FourDollars) wrote:
> >> >> > > The Dell Latitude 5495 has the mic mute key.
> >> >> > >
> >> >> > > Signed-off-by: Shih-Yuan Lee (FourDollars) <sylee@canonical.com>
> >> >> > > ---
> >> >> > >  drivers/platform/x86/dell-wmi.c | 3 +++
> >> >> > >  1 file changed, 3 insertions(+)
> >> >> > >
> >> >> > > diff --git a/drivers/platform/x86/dell-wmi.c
> >> >> > b/drivers/platform/x86/dell-wmi.c
> >> >> > > index fb25b20..d40f803 100644
> >> >> > > --- a/drivers/platform/x86/dell-wmi.c
> >> >> > > +++ b/drivers/platform/x86/dell-wmi.c
> >> >> > > @@ -261,6 +261,9 @@ static const u16 bios_to_linux_keycode[256] = {
> >> >> > >   * override them.
> >> >> > >   */
> >> >> > >  static const struct key_entry dell_wmi_keymap_type_0010[] = {
> >> >> > > +     /* Mic mute */
> >> >> > > +     { KE_KEY, 0x150, { KEY_F20 } },
> >> >> >
> >> >> > Hi! Are you sure that this key code needs to be in 0010 table? Because
> >> >> > primary this table is constructed from DMI information. See
> >> >> > array bios_to_linux_keycode[].
> >> >> >
> >> >> Because I saw "dell_wmi: Unknown key with type 0x0010 and code 0x0150
> >> >> pressed" in dmesg when pressing the mic mute key.
> >> >
> >> > And do you see following message?
> >> > "firmware scancode 0x%x maps to unrecognized keycode 0x%x\n"
> >> No, do I put some specific kernel parameter to see it?
> >
> > It is print in same way as above Unknown key with type ...
> OK, I saw "dell_wmi: Unknown key with type 0x0010 and code 0x0150 pressed".
> There is no "firmware scancode 0x%x maps to unrecognized keycode 0x%x\n" at all.

Ok, then adding additional entry is needed.

-- 
Pali Rohár
pali.rohar@gmail.com