From: Ivan Vecera <ivecera@redhat.com>
To: platform-driver-x86@vger.kernel.org
Cc: "Vadim Pasternak" <vadimp@mellanox.com>,
"Bjørn Mork" <bjorn@mork.no>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: [PATCH v3] platform/x86: mlx-platform: fix module aliases
Date: Mon, 22 Jan 2018 15:20:43 +0100 [thread overview]
Message-ID: <20180122142043.23705-1-ivecera@redhat.com> (raw)
Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is
not loaded automatically. The driver should use MODULE_DEVICE_TABLE
together with existing mlxplat_dmi_table instead.
Changes:
v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)
v3 - MODULE_DEVICE_TABLE moved after mlxplat_dmi_table declaration
Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from arch/x86")
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Bjørn Mork <bjorn@mork.no>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/platform/x86/mlx-platform.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 504256c3660d..22cd011f6aee 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -286,6 +286,8 @@ static const struct dmi_system_id mlxplat_dmi_table[] __initconst = {
{ }
};
+MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
+
static int __init mlxplat_init(void)
{
struct mlxplat_priv *priv;
@@ -370,8 +372,3 @@ module_exit(mlxplat_exit);
MODULE_AUTHOR("Vadim Pasternak (vadimp@mellanox.com)");
MODULE_DESCRIPTION("Mellanox platform driver");
MODULE_LICENSE("Dual BSD/GPL");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
--
2.13.6
next reply other threads:[~2018-01-22 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 14:20 Ivan Vecera [this message]
2018-01-22 14:22 ` [PATCH v3] platform/x86: mlx-platform: fix module aliases Vadim Pasternak
2018-02-01 6:10 ` Vadim Pasternak
2018-02-01 23:32 ` dvhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122142043.23705-1-ivecera@redhat.com \
--to=ivecera@redhat.com \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn@mork.no \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox