* [PATCH v3] platform/x86: mlx-platform: fix module aliases
@ 2018-01-22 14:20 Ivan Vecera
2018-01-22 14:22 ` Vadim Pasternak
2018-02-01 6:10 ` Vadim Pasternak
0 siblings, 2 replies; 4+ messages in thread
From: Ivan Vecera @ 2018-01-22 14:20 UTC (permalink / raw)
To: platform-driver-x86; +Cc: Vadim Pasternak, Bjørn Mork, Andy Shevchenko
Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is
not loaded automatically. The driver should use MODULE_DEVICE_TABLE
together with existing mlxplat_dmi_table instead.
Changes:
v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)
v3 - MODULE_DEVICE_TABLE moved after mlxplat_dmi_table declaration
Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from arch/x86")
Cc: Vadim Pasternak <vadimp@mellanox.com>
Cc: Bjørn Mork <bjorn@mork.no>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/platform/x86/mlx-platform.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 504256c3660d..22cd011f6aee 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -286,6 +286,8 @@ static const struct dmi_system_id mlxplat_dmi_table[] __initconst = {
{ }
};
+MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
+
static int __init mlxplat_init(void)
{
struct mlxplat_priv *priv;
@@ -370,8 +372,3 @@ module_exit(mlxplat_exit);
MODULE_AUTHOR("Vadim Pasternak (vadimp@mellanox.com)");
MODULE_DESCRIPTION("Mellanox platform driver");
MODULE_LICENSE("Dual BSD/GPL");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
-MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH v3] platform/x86: mlx-platform: fix module aliases
2018-01-22 14:20 [PATCH v3] platform/x86: mlx-platform: fix module aliases Ivan Vecera
@ 2018-01-22 14:22 ` Vadim Pasternak
2018-02-01 6:10 ` Vadim Pasternak
1 sibling, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2018-01-22 14:22 UTC (permalink / raw)
To: Ivan Vecera, platform-driver-x86@vger.kernel.org
Cc: Bjørn Mork, Andy Shevchenko
> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> Sent: Monday, January 22, 2018 4:21 PM
> To: platform-driver-x86@vger.kernel.org
> Cc: Vadim Pasternak <vadimp@mellanox.com>; Bjørn Mork <bjorn@mork.no>;
> Andy Shevchenko <andy.shevchenko@gmail.com>
> Subject: [PATCH v3] platform/x86: mlx-platform: fix module aliases
>
> Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is not loaded
> automatically. The driver should use MODULE_DEVICE_TABLE together with
> existing mlxplat_dmi_table instead.
>
> Changes:
> v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)
> v3 - MODULE_DEVICE_TABLE moved after mlxplat_dmi_table declaration
>
> Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from
> arch/x86")
> Cc: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Bjørn Mork <bjorn@mork.no>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> ---
> drivers/platform/x86/mlx-platform.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index 504256c3660d..22cd011f6aee 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -286,6 +286,8 @@ static const struct dmi_system_id mlxplat_dmi_table[]
> __initconst = {
> { }
> };
>
> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
> +
> static int __init mlxplat_init(void)
> {
> struct mlxplat_priv *priv;
> @@ -370,8 +372,3 @@ module_exit(mlxplat_exit); MODULE_AUTHOR("Vadim
> Pasternak (vadimp@mellanox.com)"); MODULE_DESCRIPTION("Mellanox
> platform driver"); MODULE_LICENSE("Dual BSD/GPL"); -
> MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
> --
> 2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v3] platform/x86: mlx-platform: fix module aliases
2018-01-22 14:20 [PATCH v3] platform/x86: mlx-platform: fix module aliases Ivan Vecera
2018-01-22 14:22 ` Vadim Pasternak
@ 2018-02-01 6:10 ` Vadim Pasternak
2018-02-01 23:32 ` dvhart
1 sibling, 1 reply; 4+ messages in thread
From: Vadim Pasternak @ 2018-02-01 6:10 UTC (permalink / raw)
To: Ivan Vecera, platform-driver-x86@vger.kernel.org, Darren Hart
Cc: Bjørn Mork, Andy Shevchenko
> -----Original Message-----
> From: Ivan Vecera [mailto:ivecera@redhat.com]
> Sent: Monday, January 22, 2018 4:21 PM
> To: platform-driver-x86@vger.kernel.org
> Cc: Vadim Pasternak <vadimp@mellanox.com>; Bjørn Mork <bjorn@mork.no>;
> Andy Shevchenko <andy.shevchenko@gmail.com>
> Subject: [PATCH v3] platform/x86: mlx-platform: fix module aliases
>
> Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is not loaded
> automatically. The driver should use MODULE_DEVICE_TABLE together with
> existing mlxplat_dmi_table instead.
Darren/Andy,
Since mlx-platform is about to be modified in for-next, how to proceed on this
patch? Could I resend it based on top of the latest version?
>
> Changes:
> v2 - conversion to usage of MODULE_DEVICE_TABLE (thanks Bjørn)
> v3 - MODULE_DEVICE_TABLE moved after mlxplat_dmi_table declaration
>
> Fixes: 6613d18e9038 ("platform/x86: mlx-platform: Move module from
> arch/x86")
> Cc: Vadim Pasternak <vadimp@mellanox.com>
> Cc: Bjørn Mork <bjorn@mork.no>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> drivers/platform/x86/mlx-platform.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index 504256c3660d..22cd011f6aee 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -286,6 +286,8 @@ static const struct dmi_system_id mlxplat_dmi_table[]
> __initconst = {
> { }
> };
>
> +MODULE_DEVICE_TABLE(dmi, mlxplat_dmi_table);
> +
> static int __init mlxplat_init(void)
> {
> struct mlxplat_priv *priv;
> @@ -370,8 +372,3 @@ module_exit(mlxplat_exit); MODULE_AUTHOR("Vadim
> Pasternak (vadimp@mellanox.com)"); MODULE_DESCRIPTION("Mellanox
> platform driver"); MODULE_LICENSE("Dual BSD/GPL"); -
> MODULE_ALIAS("dmi:*:*Mellanox*:MSN24*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN27*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSB*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSX*:");
> -MODULE_ALIAS("dmi:*:*Mellanox*:MSN21*:");
> --
> 2.13.6
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v3] platform/x86: mlx-platform: fix module aliases
2018-02-01 6:10 ` Vadim Pasternak
@ 2018-02-01 23:32 ` dvhart
0 siblings, 0 replies; 4+ messages in thread
From: dvhart @ 2018-02-01 23:32 UTC (permalink / raw)
To: Vadim Pasternak, Ivan Vecera, platform-driver-x86@vger.kernel.org
Cc: Bjørn Mork, Andy Shevchenko
On January 31, 2018 10:10:39 PM PST, Vadim Pasternak <vadimp@mellanox.com> wrote:
>
>
>> -----Original Message-----
>> From: Ivan Vecera [mailto:ivecera@redhat.com]
>> Sent: Monday, January 22, 2018 4:21 PM
>> To: platform-driver-x86@vger.kernel.org
>> Cc: Vadim Pasternak <vadimp@mellanox.com>; Bjørn Mork
><bjorn@mork.no>;
>> Andy Shevchenko <andy.shevchenko@gmail.com>
>> Subject: [PATCH v3] platform/x86: mlx-platform: fix module aliases
>>
>> Missing prefix 'pn' in MODULE_ALIAS lines causes that the module is
>not loaded
>> automatically. The driver should use MODULE_DEVICE_TABLE together
>with
>> existing mlxplat_dmi_table instead.
>
>Darren/Andy,
>Since mlx-platform is about to be modified in for-next, how to proceed
>on this
>patch? Could I resend it based on top of the latest version?
This patch is applied in testing already.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-01 23:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-22 14:20 [PATCH v3] platform/x86: mlx-platform: fix module aliases Ivan Vecera
2018-01-22 14:22 ` Vadim Pasternak
2018-02-01 6:10 ` Vadim Pasternak
2018-02-01 23:32 ` dvhart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox