* [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
@ 2018-01-25 22:48 Alexander Abrosimov
2018-01-25 23:02 ` Darren Hart
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Abrosimov @ 2018-01-25 22:48 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel, Alexander Abrosimov
SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
2-in-1 devices like tablets, convertibles and detachables. Dell's
Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
be added to the DMI whitelist, so rfkill and backlight can be controlled
for them as for other laptops.
Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index cd4725e7e0b5..23fc94d70ea1 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
},
},
{
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
+ },
+ },
+ {
.ident = "Dell Computer Corporation",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
--
2.13.6
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
2018-01-25 22:48 [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist Alexander Abrosimov
@ 2018-01-25 23:02 ` Darren Hart
2018-01-25 23:06 ` Pali Rohár
0 siblings, 1 reply; 6+ messages in thread
From: Darren Hart @ 2018-01-25 23:02 UTC (permalink / raw)
To: Alexander Abrosimov
Cc: Matthew Garrett, Pali Rohár, Mario Limonciello,
Andy Shevchenko, platform-driver-x86, linux-kernel
On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> 2-in-1 devices like tablets, convertibles and detachables. Dell's
> Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> be added to the DMI whitelist, so rfkill and backlight can be controlled
> for them as for other laptops.
>
> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
respond before merging...
> ---
> drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index cd4725e7e0b5..23fc94d70ea1 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> },
> },
> {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> + },
> + },
> + {
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> + },
> + },
> + {
> .ident = "Dell Computer Corporation",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> --
> 2.13.6
>
>
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
2018-01-25 23:02 ` Darren Hart
@ 2018-01-25 23:06 ` Pali Rohár
2018-01-26 14:42 ` Mario.Limonciello
0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2018-01-25 23:06 UTC (permalink / raw)
To: Darren Hart
Cc: Alexander Abrosimov, Matthew Garrett, Mario Limonciello,
Andy Shevchenko, platform-driver-x86, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
On Thursday 25 January 2018 15:02:39 Darren Hart wrote:
> On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> > 2-in-1 devices like tablets, convertibles and detachables. Dell's
> > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> > be added to the DMI whitelist, so rfkill and backlight can be controlled
> > for them as for other laptops.
> >
> > Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
>
> Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
> respond before merging...
I have no comments for this. This should be confirmed by Mario or
somebody else from Dell, which DMI names are used for a new products.
> > ---
> > drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> > index cd4725e7e0b5..23fc94d70ea1 100644
> > --- a/drivers/platform/x86/dell-laptop.c
> > +++ b/drivers/platform/x86/dell-laptop.c
> > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> > },
> > },
> > {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> > + },
> > + },
> > + {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> > + },
> > + },
> > + {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> > + },
> > + },
> > + {
> > .ident = "Dell Computer Corporation",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> > --
> > 2.13.6
> >
> >
>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
2018-01-25 23:06 ` Pali Rohár
@ 2018-01-26 14:42 ` Mario.Limonciello
2018-02-07 13:47 ` Alexander Abrosimov
0 siblings, 1 reply; 6+ messages in thread
From: Mario.Limonciello @ 2018-01-26 14:42 UTC (permalink / raw)
To: pali.rohar, dvhart
Cc: alexander.n.abrosimov, mjg59, andy, platform-driver-x86,
linux-kernel
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Thursday, January 25, 2018 5:06 PM
> To: Darren Hart <dvhart@infradead.org>
> Cc: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>; Matthew Garrett
> <mjg59@srcf.ucam.org>; Limonciello, Mario <Mario_Limonciello@Dell.com>; Andy
> Shevchenko <andy@infradead.org>; platform-driver-x86@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI
> whitelist
>
> On Thursday 25 January 2018 15:02:39 Darren Hart wrote:
> > On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> > > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> > > 2-in-1 devices like tablets, convertibles and detachables. Dell's
> > > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> > > be added to the DMI whitelist, so rfkill and backlight can be controlled
> > > for them as for other laptops.
> > >
> > > Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
> >
> > Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
> > respond before merging...
>
> I have no comments for this. This should be confirmed by Mario or
> somebody else from Dell, which DMI names are used for a new products.
Yes these chassis types from SMBIOS 3.0 are covered by Dell specs and used for
some products.
This patch looks good to me.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
>
> > > ---
> > > drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> > > 1 file changed, 18 insertions(+)
> > >
> > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-
> laptop.c
> > > index cd4725e7e0b5..23fc94d70ea1 100644
> > > --- a/drivers/platform/x86/dell-laptop.c
> > > +++ b/drivers/platform/x86/dell-laptop.c
> > > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[]
> __initconst = {
> > > },
> > > },
> > > {
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> > > + },
> > > + },
> > > + {
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> > > + },
> > > + },
> > > + {
> > > + .matches = {
> > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> > > + },
> > > + },
> > > + {
> > > .ident = "Dell Computer Corporation",
> > > .matches = {
> > > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> Corporation"),
> > > --
> > > 2.13.6
> > >
> > >
> >
>
> --
> Pali Rohár
> pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
2018-01-26 14:42 ` Mario.Limonciello
@ 2018-02-07 13:47 ` Alexander Abrosimov
2018-02-07 14:18 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Abrosimov @ 2018-02-07 13:47 UTC (permalink / raw)
To: Darren Hart
Cc: Pali Rohár, Mario.Limonciello, Matthew Garrett,
Andy Shevchenko, platform-driver-x86, linux-kernel
Darren, I have checked change on git.kernel.org and it seems to be merged twice:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/x86/dell-laptop.c?id=fe486138788ba435ffa918c8d7aba05a77b6289a
How it can be fixed?
2018-01-26 17:42 GMT+03:00 <Mario.Limonciello@dell.com>:
>
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Thursday, January 25, 2018 5:06 PM
> > To: Darren Hart <dvhart@infradead.org>
> > Cc: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>; Matthew Garrett
> > <mjg59@srcf.ucam.org>; Limonciello, Mario <Mario_Limonciello@Dell.com>; Andy
> > Shevchenko <andy@infradead.org>; platform-driver-x86@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI
> > whitelist
> >
> > On Thursday 25 January 2018 15:02:39 Darren Hart wrote:
> > > On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> > > > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> > > > 2-in-1 devices like tablets, convertibles and detachables. Dell's
> > > > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> > > > be added to the DMI whitelist, so rfkill and backlight can be controlled
> > > > for them as for other laptops.
> > > >
> > > > Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
> > >
> > > Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
> > > respond before merging...
> >
> > I have no comments for this. This should be confirmed by Mario or
> > somebody else from Dell, which DMI names are used for a new products.
>
> Yes these chassis types from SMBIOS 3.0 are covered by Dell specs and used for
> some products.
>
> This patch looks good to me.
>
> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
> >
> > > > ---
> > > > drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> > > > 1 file changed, 18 insertions(+)
> > > >
> > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-
> > laptop.c
> > > > index cd4725e7e0b5..23fc94d70ea1 100644
> > > > --- a/drivers/platform/x86/dell-laptop.c
> > > > +++ b/drivers/platform/x86/dell-laptop.c
> > > > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[]
> > __initconst = {
> > > > },
> > > > },
> > > > {
> > > > + .matches = {
> > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> > > > + },
> > > > + },
> > > > + {
> > > > + .matches = {
> > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> > > > + },
> > > > + },
> > > > + {
> > > > + .matches = {
> > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> > > > + },
> > > > + },
> > > > + {
> > > > .ident = "Dell Computer Corporation",
> > > > .matches = {
> > > > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> > Corporation"),
> > > > --
> > > > 2.13.6
> > > >
> > > >
> > >
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
--
Best Regards,
Abrosimov Alexander, mailto:alexander.n.abrosimov@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
2018-02-07 13:47 ` Alexander Abrosimov
@ 2018-02-07 14:18 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2018-02-07 14:18 UTC (permalink / raw)
To: Alexander Abrosimov
Cc: Darren Hart, Pali Rohár, Mario Limonciello, Matthew Garrett,
Andy Shevchenko, Platform Driver, Linux Kernel Mailing List
On Wed, Feb 7, 2018 at 3:47 PM, Alexander Abrosimov
<alexander.n.abrosimov@gmail.com> wrote:
> Darren, I have checked change on git.kernel.org and it seems to be merged twice:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/x86/dell-laptop.c?id=fe486138788ba435ffa918c8d7aba05a77b6289a
>
> How it can be fixed?
First of all, please, do not top post!
WRT the report, as I can see it's not fatal or anyhow affecting the
normal workflow.
Thus, just sent a regular patch to remove duplicate entries.
I don't see necessity to send that fix to stable@ because it wouldn't
fix any bugs or regressions.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-07 14:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-25 22:48 [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist Alexander Abrosimov
2018-01-25 23:02 ` Darren Hart
2018-01-25 23:06 ` Pali Rohár
2018-01-26 14:42 ` Mario.Limonciello
2018-02-07 13:47 ` Alexander Abrosimov
2018-02-07 14:18 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox