X86 platform drivers
 help / color / mirror / Atom feed
From: Harald Welte <laforge@gnumonks.org>
To: Kenneth Chan <kenneth.t.chan@gmail.com>
Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch
Date: Fri, 16 Mar 2018 12:09:07 +0100	[thread overview]
Message-ID: <20180316110907.GK3523@nataraja> (raw)
In-Reply-To: <CAPqSeKv0Q+ocBYeonxi5w8XB0vaM27O1hcDm9ZDdXxCt7Py=Pw@mail.gmail.com>

Hi Kenneth,

thanks for your fix.  I'm not currently using any Panasonic Laptop devices
anymore (After the CF-R series was discontinued), so I'm not able to properly
maintain this driver anymore.

However, your changes look sound to me (aside from that we don't use C++ style
comments in kernel source code), hence:

Acked-by: Harald Welte <laforge@gnumonks.org>

-- 
- Harald Welte <laforge@gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

       reply	other threads:[~2018-03-16 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAPqSeKv0Q+ocBYeonxi5w8XB0vaM27O1hcDm9ZDdXxCt7Py=Pw@mail.gmail.com>
2018-03-16 11:09 ` Harald Welte [this message]
2018-03-16 18:38   ` [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180316110907.GK3523@nataraja \
    --to=laforge@gnumonks.org \
    --cc=kenneth.t.chan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox