* Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch
[not found] <CAPqSeKv0Q+ocBYeonxi5w8XB0vaM27O1hcDm9ZDdXxCt7Py=Pw@mail.gmail.com>
@ 2018-03-16 11:09 ` Harald Welte
2018-03-16 18:38 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Harald Welte @ 2018-03-16 11:09 UTC (permalink / raw)
To: Kenneth Chan; +Cc: linux-kernel, platform-driver-x86
Hi Kenneth,
thanks for your fix. I'm not currently using any Panasonic Laptop devices
anymore (After the CF-R series was discontinued), so I'm not able to properly
maintain this driver anymore.
However, your changes look sound to me (aside from that we don't use C++ style
comments in kernel source code), hence:
Acked-by: Harald Welte <laforge@gnumonks.org>
--
- Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch
2018-03-16 11:09 ` [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch Harald Welte
@ 2018-03-16 18:38 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2018-03-16 18:38 UTC (permalink / raw)
To: Harald Welte; +Cc: Kenneth Chan, Linux Kernel Mailing List, Platform Driver
On Fri, Mar 16, 2018 at 1:09 PM, Harald Welte <laforge@gnumonks.org> wrote:
> Hi Kenneth,
>
> thanks for your fix. I'm not currently using any Panasonic Laptop devices
> anymore (After the CF-R series was discontinued), so I'm not able to properly
> maintain this driver anymore.
>
> However, your changes look sound to me (aside from that we don't use C++ style
> comments in kernel source code), hence:
>
> Acked-by: Harald Welte <laforge@gnumonks.org>
I'm not sure I ever seen the original patch. Patchwork also misses it.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-16 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAPqSeKv0Q+ocBYeonxi5w8XB0vaM27O1hcDm9ZDdXxCt7Py=Pw@mail.gmail.com>
2018-03-16 11:09 ` [PATCH] platform/x86: panasonic-laptop: add support to mute and hardware optical switch Harald Welte
2018-03-16 18:38 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox