* [PATCH v6 04/11] platform/x86: intel_ips: make PCI dependency explicit [not found] <20190105100606.6673-1-okaya@kernel.org> @ 2019-01-05 10:05 ` Sinan Kaya 2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya 2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya 2 siblings, 0 replies; 6+ messages in thread From: Sinan Kaya @ 2019-01-05 10:05 UTC (permalink / raw) To: linux-next Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko, open list:X86 PLATFORM DRIVERS, open list After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. Ipss driver is a PCI device driver but this has not been mentioned anywhere in Kconfig. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index e3b62c2ee8d1..b36ea14b41ad 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL config INTEL_IPS tristate "Intel Intelligent Power Sharing" - depends on ACPI + depends on ACPI && PCI ---help--- Intel Calpella platforms support dynamic power sharing between the CPU and GPU, maximizing performance in a given TDP. This driver, -- 2.19.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit [not found] <20190105100606.6673-1-okaya@kernel.org> 2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: make PCI dependency explicit Sinan Kaya @ 2019-01-05 10:06 ` Sinan Kaya 2019-01-09 10:47 ` Rafael J. Wysocki 2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya 2 siblings, 1 reply; 6+ messages in thread From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw) To: linux-next Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko, open list:X86 PLATFORM DRIVERS, open list After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. Code relies on PCI for execution. Specify this in the Kconfig. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index b36ea14b41ad..7afb96cb1cd6 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communication -- 2.19.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit 2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya @ 2019-01-09 10:47 ` Rafael J. Wysocki 2019-01-09 11:10 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Rafael J. Wysocki @ 2019-01-09 10:47 UTC (permalink / raw) To: Sinan Kaya, Andy Shevchenko Cc: linux-next, linux-acpi, Darren Hart, open list:X86 PLATFORM DRIVERS, open list On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote: > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > satisfied implicitly through dependencies on CONFIG_ACPI have to be > specified directly. Code relies on PCI for execution. Specify this > in the Kconfig. > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index b36ea14b41ad..7afb96cb1cd6 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT > > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > - depends on ACPI > + depends on ACPI && PCI > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication Andy, you had some reservations regarding this patch IIRC. Should I apply it? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit 2019-01-09 10:47 ` Rafael J. Wysocki @ 2019-01-09 11:10 ` Andy Shevchenko 2019-01-15 18:40 ` Rafael J. Wysocki 0 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2019-01-09 11:10 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Sinan Kaya, Andy Shevchenko, linux-next, ACPI Devel Maling List, Darren Hart, open list:X86 PLATFORM DRIVERS, open list On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote: > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > > satisfied implicitly through dependencies on CONFIG_ACPI have to be > > specified directly. Code relies on PCI for execution. Specify this > > in the Kconfig. > > > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > > Signed-off-by: Sinan Kaya <okaya@kernel.org> > > --- > > drivers/platform/x86/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > index b36ea14b41ad..7afb96cb1cd6 100644 > > --- a/drivers/platform/x86/Kconfig > > +++ b/drivers/platform/x86/Kconfig > > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT > > > > config INTEL_PMC_IPC > > tristate "Intel PMC IPC Driver" > > - depends on ACPI > > + depends on ACPI && PCI > > ---help--- > > This driver provides support for PMC control on some Intel platforms. > > The PMC is an ARC processor which defines IPC commands for communication > > Andy, you had some reservations regarding this patch IIRC. > > Should I apply it? Let's do it as a quick fix with something like below being added to the commit message: "For sake of a quick fix this introduces a new mandatory dependency to the driver which may survive without it. Otherwise we need to revisit the driver architecture to address this properly." -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit 2019-01-09 11:10 ` Andy Shevchenko @ 2019-01-15 18:40 ` Rafael J. Wysocki 0 siblings, 0 replies; 6+ messages in thread From: Rafael J. Wysocki @ 2019-01-15 18:40 UTC (permalink / raw) To: Andy Shevchenko Cc: Sinan Kaya, Andy Shevchenko, linux-next, ACPI Devel Maling List, Darren Hart, open list:X86 PLATFORM DRIVERS, open list On Wednesday, January 9, 2019 12:10:45 PM CET Andy Shevchenko wrote: > On Wed, Jan 9, 2019 at 12:48 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > > On Saturday, January 5, 2019 11:06:00 AM CET Sinan Kaya wrote: > > > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without > > > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were > > > satisfied implicitly through dependencies on CONFIG_ACPI have to be > > > specified directly. Code relies on PCI for execution. Specify this > > > in the Kconfig. > > > > > > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") > > > Signed-off-by: Sinan Kaya <okaya@kernel.org> > > > --- > > > drivers/platform/x86/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > > index b36ea14b41ad..7afb96cb1cd6 100644 > > > --- a/drivers/platform/x86/Kconfig > > > +++ b/drivers/platform/x86/Kconfig > > > @@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT > > > > > > config INTEL_PMC_IPC > > > tristate "Intel PMC IPC Driver" > > > - depends on ACPI > > > + depends on ACPI && PCI > > > ---help--- > > > This driver provides support for PMC control on some Intel platforms. > > > The PMC is an ARC processor which defines IPC commands for communication > > > > Andy, you had some reservations regarding this patch IIRC. > > > > Should I apply it? > > Let's do it as a quick fix with something like below being added to > the commit message: > > "For sake of a quick fix this introduces a new mandatory dependency to > the driver which may survive without it. Otherwise we need to revisit > the driver architecture to address this properly." Done, thanks! ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v6 06/11] platform/x86: apple-gmux: Make PCI dependency explicit [not found] <20190105100606.6673-1-okaya@kernel.org> 2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: make PCI dependency explicit Sinan Kaya 2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya @ 2019-01-05 10:06 ` Sinan Kaya 2 siblings, 0 replies; 6+ messages in thread From: Sinan Kaya @ 2019-01-05 10:06 UTC (permalink / raw) To: linux-next Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko, open list:X86 PLATFORM DRIVERS, open list After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This driver depends on the PCI infrastructure but the dependency has not been explicitly called out. Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") Signed-off-by: Sinan Kaya <okaya@kernel.org> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 7afb96cb1cd6..5e2109c54c7c 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1135,7 +1135,7 @@ config SAMSUNG_Q10 config APPLE_GMUX tristate "Apple Gmux Driver" - depends on ACPI + depends on ACPI && PCI depends on PNP depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE -- 2.19.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-15 18:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190105100606.6673-1-okaya@kernel.org>
2019-01-05 10:05 ` [PATCH v6 04/11] platform/x86: intel_ips: make PCI dependency explicit Sinan Kaya
2019-01-05 10:06 ` [PATCH v6 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2019-01-09 10:47 ` Rafael J. Wysocki
2019-01-09 11:10 ` Andy Shevchenko
2019-01-15 18:40 ` Rafael J. Wysocki
2019-01-05 10:06 ` [PATCH v6 06/11] platform/x86: apple-gmux: " Sinan Kaya
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox