Re: Bugfix thinkpad_acpi.c / proper fanquirk-matching for P50 series

Re: Bugfix thinkpad_acpi.c / proper fanquirk-matching for P50 series

[Andy Shevchenko]

On Wed, Mar 27, 2019 at 12:32:50PM +0100, Matthias Hensler wrote:
> Hi Andy,
> 
> as far as I see you are responsible for pushing bugfixes to the
> thinkpad_acpi-module. If not please point me in the correct direction,
> thanks a lot.

Thanks for the report and fix.

The best way to submit this is to use kernel source tree, where you can run

scripts/get_maintainer.pl -f drivers/platform/x86/thinkpad_acpi.c

to get people responsible for the driver in upstream, followed by

git format-patch ... (you need to commit your fix first)
git send-email...

commands.

For your convenience I Cc'ed this mail to all stakeholders, though it doesn't
abrogate the need to follow the process described above.

> Commit 846a416b4630fc960c10500b4194ad504bc22d4b changed the
> quirk-matching for modern thinkpads to use three characters instead of
> two. Unfortunately that commit did break the fan-quirk matching for my
> P50. With commit 599eefffcf6b9cff3e8cc2d96fd8eebfadab339c there were
> some cleanups in the quirk-macros, but still did not fix the wrong
> matching for the P50.
> 
> Please find attached a patch to fix the quirk-macro to properly detect
> the second fan on the P50 (Modell N1Exxx). I guess there should be some
> additional definitions for the P70 and newer P-series, but I do not know
> the exact model-numbers unfortunately.
> 
> 
> Additional what I would also like to see, is a possibility to also
> control the second fan. I use a modified version of a patch that was
> posted some years ago to the mailinglist for that, but it is really
> ugly. If you want I can try to reimplement that in a cleaner way, but
> for now at least the wrong quirk-matching should be fixed. Thanks again.
> 
> 
> Regards,
> Matthias

> --- thinkpad_acpi.c	2019-03-27 12:26:11.977106074 +0100
> +++ thinkpad_acpi.c.fixed	2019-03-27 12:27:44.090340050 +0100
> @@ -8721,7 +8721,7 @@
>  	TPACPI_QEC_IBM('7', '6', TPACPI_FAN_Q1),
>  	TPACPI_QEC_IBM('7', '0', TPACPI_FAN_Q1),
>  	TPACPI_QEC_LNV('7', 'M', TPACPI_FAN_2FAN),
> -	TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN),
> +	TPACPI_Q_LNV3('N', '1', 'E', TPACPI_FAN_2FAN),
>  };
>  
>  static int __init fan_init(struct ibm_init_struct *iibm)




-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] fix fan-quirk macro for Lenovo P50

[Andy Shevchenko]

On Wed, Mar 27, 2019 at 9:25 PM Matthias Hensler <matthias-zx6oZbK/1Go@public.gmane.org> wrote:
>
> Commit 846a416b4630fc960c10500b4194ad504bc22d4b changed the
> quirk-matching for modern thinkpads to use three characters instead of
> two. Unfortunately that commit did break the fan-quirk matching for the
> P50. With commit 599eefffcf6b9cff3e8cc2d96fd8eebfadab339c there were
> some cleanups in the quirk-macros, but still did not fix the wrong
> matching for the P50.
>
> Note: I guess the quirk-list needs to be expanded for the P70 and
>       newer models.

You need to put your Signed-off-by tag as well.
This is according to the process:
https://www.kernel.org/doc/Documentation/process/submitting-patches.rst

In any case, don't send updated version right now. We still have time
in this release cycle and I would like to hear Henrique and others
opinions.

> ---
>  drivers/platform/x86/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 726341f2b638..575a1ea161f0 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8721,7 +8721,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
>         TPACPI_QEC_IBM('7', '6', TPACPI_FAN_Q1),
>         TPACPI_QEC_IBM('7', '0', TPACPI_FAN_Q1),
>         TPACPI_QEC_LNV('7', 'M', TPACPI_FAN_2FAN),
> -       TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN),
> +       TPACPI_Q_LNV3('N', '1', 'E', TPACPI_FAN_2FAN),
>  };
>
>  static int __init fan_init(struct ibm_init_struct *iibm)
> --
> 2.20.1
>


-- 
With Best Regards,
Andy Shevchenko