From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Vadim Pasternak <vadimp@mellanox.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Darren Hart <dvhart@infradead.org>,
virtualization@lists.linux-foundation.org,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access
Date: Wed, 5 Aug 2020 09:29:12 -0400 [thread overview]
Message-ID: <20200805092904-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200804165634.4df11c6b.cohuck@redhat.com>
On Tue, Aug 04, 2020 at 04:56:34PM +0200, Cornelia Huck wrote:
> On Mon, 3 Aug 2020 17:00:01 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > mlxbf-tmfifo accesses config space using native types -
> > which works for it since the legacy virtio native types.
> >
> > This will break if it ever needs to support modern virtio,
> > so with new tags previously introduced for virtio net config,
> > sparse now warns for this in drivers.
> >
> > Since this is a legacy only device, fix it up using
> > virtio_legacy_is_little_endian for now.
>
> I'm wondering if the driver should make this more explicit?
Not sure how though.
> No issues with the patch, though.
>
> >
> > No functional changes.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2020-08-05 13:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200803205814.540410-1-mst@redhat.com>
2020-08-03 21:00 ` [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access Michael S. Tsirkin
2020-08-04 14:56 ` Cornelia Huck
2020-08-05 13:29 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805092904-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=andy@infradead.org \
--cc=cohuck@redhat.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox