public inbox for platform-driver-x86@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1
@ 2022-01-04  8:19 yuk7
  2022-01-11 11:00 ` Hans de Goede
  2022-01-11 15:40 ` yuk7
  0 siblings, 2 replies; 4+ messages in thread
From: yuk7 @ 2022-01-04  8:19 UTC (permalink / raw)
  To: hdegoede; +Cc: platform-driver-x86, yuk7

Add touchscreen info for RWC NANOTE P8 (AY07J) 2-in-1.

Signed-off-by: yuk7 <yukx00@gmail.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 17dd54d4b..e318b4094 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -773,6 +773,21 @@ static const struct ts_dmi_data predia_basic_data = {
 	.properties	= predia_basic_props,
 };
 
+static const struct property_entry rwc_nanote_p8_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 46),
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-rwc-nanote-p8.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	{ }
+};
+
+static const struct ts_dmi_data rwc_nanote_p8_data = {
+	.acpi_name = "MSSL1680:00",
+	.properties = rwc_nanote_p8_props,
+};
+
 static const struct property_entry schneider_sct101ctm_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
 	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1406,6 +1421,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
 		},
 	},
+	{
+		/* RWC NANOTE P8 */
+		.driver_data = (void *)&rwc_nanote_p8_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Default string"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AY07J"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "0001")
+		},
+	},
 	{
 		/* Schneider SCT101CTM */
 		.driver_data = (void *)&schneider_sct101ctm_data,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1
  2022-01-04  8:19 [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1 yuk7
@ 2022-01-11 11:00 ` Hans de Goede
  2022-01-11 15:40 ` yuk7
  1 sibling, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-01-11 11:00 UTC (permalink / raw)
  To: yuk7; +Cc: platform-driver-x86

Hi,

On 1/4/22 09:19, yuk7 wrote:
> Add touchscreen info for RWC NANOTE P8 (AY07J) 2-in-1.
> 
> Signed-off-by: yuk7 <yukx00@gmail.com>

Thank you for your patch.

I'm afraid that the kernel rules do not allow accepting patches submitted
under a nickname.

Given that this patch is mostly data, not code, I can set
myself as author, crediting you like this:

Reported-and-tested-by: yuk7 <yukx00@gmail.com>

And then merge it with me as the author, or you can resubmit
it using "realname - real-last-name" in the author and
signed-off-by fields (using the yukx00@gmail.com email address
is fine).

Please let me know how you want to proceed with this.

Regards,

Hans



> ---
>  drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 17dd54d4b..e318b4094 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -773,6 +773,21 @@ static const struct ts_dmi_data predia_basic_data = {
>  	.properties	= predia_basic_props,
>  };
>  
> +static const struct property_entry rwc_nanote_p8_props[] = {
> +	PROPERTY_ENTRY_U32("touchscreen-min-y", 46),
> +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> +	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-rwc-nanote-p8.fw"),
> +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> +	{ }
> +};
> +
> +static const struct ts_dmi_data rwc_nanote_p8_data = {
> +	.acpi_name = "MSSL1680:00",
> +	.properties = rwc_nanote_p8_props,
> +};
> +
>  static const struct property_entry schneider_sct101ctm_props[] = {
>  	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
>  	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> @@ -1406,6 +1421,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
>  			DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
>  		},
>  	},
> +	{
> +		/* RWC NANOTE P8 */
> +		.driver_data = (void *)&rwc_nanote_p8_data,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Default string"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "AY07J"),
> +			DMI_MATCH(DMI_PRODUCT_SKU, "0001")
> +		},
> +	},
>  	{
>  		/* Schneider SCT101CTM */
>  		.driver_data = (void *)&schneider_sct101ctm_data,
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1
  2022-01-04  8:19 [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1 yuk7
  2022-01-11 11:00 ` Hans de Goede
@ 2022-01-11 15:40 ` yuk7
  2022-01-17  9:43   ` Hans de Goede
  1 sibling, 1 reply; 4+ messages in thread
From: yuk7 @ 2022-01-11 15:40 UTC (permalink / raw)
  To: hdegoede; +Cc: platform-driver-x86, yuk7

Add touchscreen info for RWC NANOTE P8 (AY07J) 2-in-1.

Signed-off-by: Yuka Kawajiri <yukx00@gmail.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 17dd54d4b..e318b4094 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -773,6 +773,21 @@ static const struct ts_dmi_data predia_basic_data = {
 	.properties	= predia_basic_props,
 };
 
+static const struct property_entry rwc_nanote_p8_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-min-y", 46),
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-rwc-nanote-p8.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	{ }
+};
+
+static const struct ts_dmi_data rwc_nanote_p8_data = {
+	.acpi_name = "MSSL1680:00",
+	.properties = rwc_nanote_p8_props,
+};
+
 static const struct property_entry schneider_sct101ctm_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
 	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
@@ -1406,6 +1421,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
 		},
 	},
+	{
+		/* RWC NANOTE P8 */
+		.driver_data = (void *)&rwc_nanote_p8_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Default string"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "AY07J"),
+			DMI_MATCH(DMI_PRODUCT_SKU, "0001")
+		},
+	},
 	{
 		/* Schneider SCT101CTM */
 		.driver_data = (void *)&schneider_sct101ctm_data,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1
  2022-01-11 15:40 ` yuk7
@ 2022-01-17  9:43   ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2022-01-17  9:43 UTC (permalink / raw)
  To: yuk7; +Cc: platform-driver-x86

Hi,

On 1/11/22 16:40, yuk7 wrote:
> Add touchscreen info for RWC NANOTE P8 (AY07J) 2-in-1.
> 
> Signed-off-by: Yuka Kawajiri <yukx00@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.


Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/touchscreen_dmi.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 17dd54d4b..e318b4094 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -773,6 +773,21 @@ static const struct ts_dmi_data predia_basic_data = {
>  	.properties	= predia_basic_props,
>  };
>  
> +static const struct property_entry rwc_nanote_p8_props[] = {
> +	PROPERTY_ENTRY_U32("touchscreen-min-y", 46),
> +	PROPERTY_ENTRY_U32("touchscreen-size-x", 1728),
> +	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> +	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
> +	PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-rwc-nanote-p8.fw"),
> +	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> +	{ }
> +};
> +
> +static const struct ts_dmi_data rwc_nanote_p8_data = {
> +	.acpi_name = "MSSL1680:00",
> +	.properties = rwc_nanote_p8_props,
> +};
> +
>  static const struct property_entry schneider_sct101ctm_props[] = {
>  	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
>  	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
> @@ -1406,6 +1421,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
>  			DMI_EXACT_MATCH(DMI_BOARD_NAME, "0E57"),
>  		},
>  	},
> +	{
> +		/* RWC NANOTE P8 */
> +		.driver_data = (void *)&rwc_nanote_p8_data,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Default string"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "AY07J"),
> +			DMI_MATCH(DMI_PRODUCT_SKU, "0001")
> +		},
> +	},
>  	{
>  		/* Schneider SCT101CTM */
>  		.driver_data = (void *)&schneider_sct101ctm_data,
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-17  9:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-04  8:19 [PATCH] platform/x86: touchscreen_dmi: Add info for the RWC NANOTE P8 AY07J 2-in-1 yuk7
2022-01-11 11:00 ` Hans de Goede
2022-01-11 15:40 ` yuk7
2022-01-17  9:43   ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox