* [PATCH platform-next 1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning
@ 2023-08-23 7:50 Vadim Pasternak
2023-08-23 11:13 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Vadim Pasternak @ 2023-08-23 7:50 UTC (permalink / raw)
To: hdegoede; +Cc: ilpo.jarvinen, platform-driver-x86, Vadim Pasternak
Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'.
Add dependency on "ACPI" to Kconfig file.
Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.
Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
drivers/platform/x86/Kconfig | 1 +
drivers/platform/x86/mlx-platform.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 06b9a5ae5a63..a43db6731f34 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
config MLX_PLATFORM
tristate "Mellanox Technologies platform support"
+ depends on ACPI
depends on I2C
select REGMAP
help
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 44f107965832..3d96dbf79a72 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);
static struct platform_driver mlxplat_driver = {
.driver = {
.name = "mlxplat",
- .acpi_match_table = ACPI_PTR(mlxplat_acpi_table),
+ .acpi_match_table = mlxplat_acpi_table,
.probe_type = PROBE_FORCE_SYNCHRONOUS,
},
.probe = mlxplat_probe,
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning
2023-08-23 7:50 [PATCH platform-next 1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning Vadim Pasternak
@ 2023-08-23 11:13 ` Hans de Goede
2023-08-23 15:27 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2023-08-23 11:13 UTC (permalink / raw)
To: Vadim Pasternak; +Cc: ilpo.jarvinen, platform-driver-x86
Hi,
On 8/23/23 09:50, Vadim Pasternak wrote:
> Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'.
>
> Add dependency on "ACPI" to Kconfig file.
> Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.
>
> Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 1 +
> drivers/platform/x86/mlx-platform.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 06b9a5ae5a63..a43db6731f34 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
>
> config MLX_PLATFORM
> tristate "Mellanox Technologies platform support"
> + depends on ACPI
> depends on I2C
> select REGMAP
> help
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
> index 44f107965832..3d96dbf79a72 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);
> static struct platform_driver mlxplat_driver = {
> .driver = {
> .name = "mlxplat",
> - .acpi_match_table = ACPI_PTR(mlxplat_acpi_table),
> + .acpi_match_table = mlxplat_acpi_table,
> .probe_type = PROBE_FORCE_SYNCHRONOUS,
> },
> .probe = mlxplat_probe,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning
2023-08-23 11:13 ` Hans de Goede
@ 2023-08-23 15:27 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-08-23 15:27 UTC (permalink / raw)
To: Vadim Pasternak; +Cc: ilpo.jarvinen, platform-driver-x86
Hi,
On 8/23/23 13:13, Hans de Goede wrote:
> Hi,
>
> On 8/23/23 09:50, Vadim Pasternak wrote:
>> Fix 0-DAY CI warning: unused variable 'mlxplat_acpi_table'.
>>
>> Add dependency on "ACPI" to Kconfig file.
>> Remove "ACPI_PTR", use plain assignment to 'mlxplat_acpi_table'.
>>
>> Fixes: e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202308231011.pa9xg8sF-lkp@intel.com/
>> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
Note I have to do a forced push to my review-hans branch due to
an author vs s-o-b mismatch which I missed earlier.
As part of that I'm going to squash this fix into the original
e2185e8f37ef ("platform: mellanox: mlx-platform: Introduce ACPI
init flow") commit.
Regards,
Hans
>> ---
>> drivers/platform/x86/Kconfig | 1 +
>> drivers/platform/x86/mlx-platform.c | 2 +-
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 06b9a5ae5a63..a43db6731f34 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -965,6 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
>>
>> config MLX_PLATFORM
>> tristate "Mellanox Technologies platform support"
>> + depends on ACPI
>> depends on I2C
>> select REGMAP
>> help
>> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
>> index 44f107965832..3d96dbf79a72 100644
>> --- a/drivers/platform/x86/mlx-platform.c
>> +++ b/drivers/platform/x86/mlx-platform.c
>> @@ -6629,7 +6629,7 @@ MODULE_DEVICE_TABLE(acpi, mlxplat_acpi_table);
>> static struct platform_driver mlxplat_driver = {
>> .driver = {
>> .name = "mlxplat",
>> - .acpi_match_table = ACPI_PTR(mlxplat_acpi_table),
>> + .acpi_match_table = mlxplat_acpi_table,
>> .probe_type = PROBE_FORCE_SYNCHRONOUS,
>> },
>> .probe = mlxplat_probe,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-23 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-23 7:50 [PATCH platform-next 1/1] platform/x86: mlx-platform: Fix 0-DAY CI warning Vadim Pasternak
2023-08-23 11:13 ` Hans de Goede
2023-08-23 15:27 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox