[PATCH v1 1/1] clk: x86: lpss-atom: Drop unneeded 'extern' in the header

[PATCH v1 1/1] clk: x86: lpss-atom: Drop unneeded 'extern' in the header

[Andy Shevchenko]

'extern' for the functions is not needed, drop it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/platform_data/x86/clk-lpss.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/x86/clk-lpss.h b/include/linux/platform_data/x86/clk-lpss.h
index 41df326583f9..7f132029316a 100644
--- a/include/linux/platform_data/x86/clk-lpss.h
+++ b/include/linux/platform_data/x86/clk-lpss.h
@@ -15,6 +15,6 @@ struct lpss_clk_data {
 	struct clk *clk;
 };
 
-extern int lpss_atom_clk_init(void);
+int lpss_atom_clk_init(void);
 
 #endif /* __CLK_LPSS_H */
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/1] clk: x86: lpss-atom: Drop unneeded 'extern' in the header

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

On Fri, 8 Dec 2023, Andy Shevchenko wrote:

> 'extern' for the functions is not needed, drop it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/linux/platform_data/x86/clk-lpss.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/platform_data/x86/clk-lpss.h b/include/linux/platform_data/x86/clk-lpss.h
> index 41df326583f9..7f132029316a 100644
> --- a/include/linux/platform_data/x86/clk-lpss.h
> +++ b/include/linux/platform_data/x86/clk-lpss.h
> @@ -15,6 +15,6 @@ struct lpss_clk_data {
>  	struct clk *clk;
>  };
>  
> -extern int lpss_atom_clk_init(void);
> +int lpss_atom_clk_init(void);

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

Re: [PATCH v1 1/1] clk: x86: lpss-atom: Drop unneeded 'extern' in the header

[Hans de Goede]

Hi,

On 12/8/23 17:52, Andy Shevchenko wrote:
> 'extern' for the functions is not needed, drop it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  include/linux/platform_data/x86/clk-lpss.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/platform_data/x86/clk-lpss.h b/include/linux/platform_data/x86/clk-lpss.h
> index 41df326583f9..7f132029316a 100644
> --- a/include/linux/platform_data/x86/clk-lpss.h
> +++ b/include/linux/platform_data/x86/clk-lpss.h
> @@ -15,6 +15,6 @@ struct lpss_clk_data {
>  	struct clk *clk;
>  };
>  
> -extern int lpss_atom_clk_init(void);
> +int lpss_atom_clk_init(void);
>  
>  #endif /* __CLK_LPSS_H */