* [PATCH AUTOSEL 5.10 09/14] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling [not found] <20240709162612.32988-1-sashal@kernel.org> @ 2024-07-09 16:25 ` Sasha Levin 2024-07-09 16:34 ` Armin Wolf 2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 10/14] platform/x86: lg-laptop: Change ACPI device id Sasha Levin 1 sibling, 1 reply; 4+ messages in thread From: Sasha Levin @ 2024-07-09 16:25 UTC (permalink / raw) To: linux-kernel, stable Cc: Armin Wolf, Agathe Boutmy, Ilpo Järvinen, Hans de Goede, Sasha Levin, matan, platform-driver-x86 From: Armin Wolf <W_Armin@gmx.de> [ Upstream commit 413c204595ca98a4f33414a948c18d7314087342 ] The rfkill hotkey handling is already provided by the wireless-hotkey driver. Remove the now unnecessary rfkill hotkey handling to avoid duplicating functionality. The ACPI notify handler still prints debugging information when receiving ACPI notifications to aid in reverse-engineering. Tested-by: Agathe Boutmy <agathe@boutmy.com> Signed-off-by: Armin Wolf <W_Armin@gmx.de> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20240606233540.9774-3-W_Armin@gmx.de Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/platform/x86/lg-laptop.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c index dd900a76d8de5..6b48e545775c0 100644 --- a/drivers/platform/x86/lg-laptop.c +++ b/drivers/platform/x86/lg-laptop.c @@ -77,7 +77,6 @@ static const struct key_entry wmi_keymap[] = { * this key both sends an event and * changes backlight level. */ - {KE_KEY, 0x80, {KEY_RFKILL} }, {KE_END, 0} }; @@ -259,14 +258,7 @@ static void wmi_input_setup(void) static void acpi_notify(struct acpi_device *device, u32 event) { - struct key_entry *key; - acpi_handle_debug(device->handle, "notify: %d\n", event); - if (inited & INIT_SPARSE_KEYMAP) { - key = sparse_keymap_entry_from_scancode(wmi_input_dev, 0x80); - if (key && key->type == KE_KEY) - sparse_keymap_report_entry(wmi_input_dev, key, 1, true); - } } static ssize_t fan_mode_store(struct device *dev, -- 2.43.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.10 09/14] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling 2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 09/14] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Sasha Levin @ 2024-07-09 16:34 ` Armin Wolf 0 siblings, 0 replies; 4+ messages in thread From: Armin Wolf @ 2024-07-09 16:34 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Agathe Boutmy, Ilpo Järvinen, Hans de Goede, matan, platform-driver-x86 Am 09.07.24 um 18:25 schrieb Sasha Levin: > From: Armin Wolf <W_Armin@gmx.de> > > [ Upstream commit 413c204595ca98a4f33414a948c18d7314087342 ] > > The rfkill hotkey handling is already provided by the wireless-hotkey > driver. Remove the now unnecessary rfkill hotkey handling to avoid > duplicating functionality. > > The ACPI notify handler still prints debugging information when > receiving ACPI notifications to aid in reverse-engineering. Hi, this depends on other patches not in kernel 5.10, please do not use this patch for kernel 5.10. Thanks, Armin Wolf > Tested-by: Agathe Boutmy <agathe@boutmy.com> > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Link: https://lore.kernel.org/r/20240606233540.9774-3-W_Armin@gmx.de > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/platform/x86/lg-laptop.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c > index dd900a76d8de5..6b48e545775c0 100644 > --- a/drivers/platform/x86/lg-laptop.c > +++ b/drivers/platform/x86/lg-laptop.c > @@ -77,7 +77,6 @@ static const struct key_entry wmi_keymap[] = { > * this key both sends an event and > * changes backlight level. > */ > - {KE_KEY, 0x80, {KEY_RFKILL} }, > {KE_END, 0} > }; > > @@ -259,14 +258,7 @@ static void wmi_input_setup(void) > > static void acpi_notify(struct acpi_device *device, u32 event) > { > - struct key_entry *key; > - > acpi_handle_debug(device->handle, "notify: %d\n", event); > - if (inited & INIT_SPARSE_KEYMAP) { > - key = sparse_keymap_entry_from_scancode(wmi_input_dev, 0x80); > - if (key && key->type == KE_KEY) > - sparse_keymap_report_entry(wmi_input_dev, key, 1, true); > - } > } > > static ssize_t fan_mode_store(struct device *dev, ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH AUTOSEL 5.10 10/14] platform/x86: lg-laptop: Change ACPI device id [not found] <20240709162612.32988-1-sashal@kernel.org> 2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 09/14] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Sasha Levin @ 2024-07-09 16:25 ` Sasha Levin 2024-07-09 16:35 ` Armin Wolf 1 sibling, 1 reply; 4+ messages in thread From: Sasha Levin @ 2024-07-09 16:25 UTC (permalink / raw) To: linux-kernel, stable Cc: Armin Wolf, Agathe Boutmy, Ilpo Järvinen, Hans de Goede, Sasha Levin, matan, platform-driver-x86 From: Armin Wolf <W_Armin@gmx.de> [ Upstream commit 58a54f27a0dac81f7fd3514be01012635219a53c ] The LGEX0815 ACPI device id is used for handling hotkey events, but this functionality is already handled by the wireless-hotkey driver. The LGEX0820 ACPI device id however is used to manage various platform features using the WMAB/WMBB ACPI methods. Use this ACPI device id to avoid blocking the wireless-hotkey driver from probing. Tested-by: Agathe Boutmy <agathe@boutmy.com> Signed-off-by: Armin Wolf <W_Armin@gmx.de> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20240606233540.9774-4-W_Armin@gmx.de Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/platform/x86/lg-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c index 6b48e545775c0..e3cf567470c8b 100644 --- a/drivers/platform/x86/lg-laptop.c +++ b/drivers/platform/x86/lg-laptop.c @@ -647,7 +647,7 @@ static int acpi_remove(struct acpi_device *device) } static const struct acpi_device_id device_ids[] = { - {"LGEX0815", 0}, + {"LGEX0820", 0}, {"", 0} }; MODULE_DEVICE_TABLE(acpi, device_ids); -- 2.43.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH AUTOSEL 5.10 10/14] platform/x86: lg-laptop: Change ACPI device id 2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 10/14] platform/x86: lg-laptop: Change ACPI device id Sasha Levin @ 2024-07-09 16:35 ` Armin Wolf 0 siblings, 0 replies; 4+ messages in thread From: Armin Wolf @ 2024-07-09 16:35 UTC (permalink / raw) To: Sasha Levin, linux-kernel, stable Cc: Agathe Boutmy, Ilpo Järvinen, Hans de Goede, matan, platform-driver-x86 Am 09.07.24 um 18:25 schrieb Sasha Levin: > From: Armin Wolf <W_Armin@gmx.de> > > [ Upstream commit 58a54f27a0dac81f7fd3514be01012635219a53c ] > > The LGEX0815 ACPI device id is used for handling hotkey events, but > this functionality is already handled by the wireless-hotkey driver. > > The LGEX0820 ACPI device id however is used to manage various > platform features using the WMAB/WMBB ACPI methods. Use this ACPI > device id to avoid blocking the wireless-hotkey driver from probing. Hi, this depends on other patches not in kernel 5.10, please do not use this patch for kernel 5.10. Thanks, Armin Wolf > > Tested-by: Agathe Boutmy <agathe@boutmy.com> > Signed-off-by: Armin Wolf <W_Armin@gmx.de> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Link: https://lore.kernel.org/r/20240606233540.9774-4-W_Armin@gmx.de > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Sasha Levin <sashal@kernel.org> > --- > drivers/platform/x86/lg-laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c > index 6b48e545775c0..e3cf567470c8b 100644 > --- a/drivers/platform/x86/lg-laptop.c > +++ b/drivers/platform/x86/lg-laptop.c > @@ -647,7 +647,7 @@ static int acpi_remove(struct acpi_device *device) > } > > static const struct acpi_device_id device_ids[] = { > - {"LGEX0815", 0}, > + {"LGEX0820", 0}, > {"", 0} > }; > MODULE_DEVICE_TABLE(acpi, device_ids); ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-09 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240709162612.32988-1-sashal@kernel.org>
2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 09/14] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling Sasha Levin
2024-07-09 16:34 ` Armin Wolf
2024-07-09 16:25 ` [PATCH AUTOSEL 5.10 10/14] platform/x86: lg-laptop: Change ACPI device id Sasha Levin
2024-07-09 16:35 ` Armin Wolf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox