From: Hans de Goede <hdegoede@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org
Subject: [PATCH v3 1/8] platform/x86: x86-android-tablets: Add missing __init to get_i2c_adap_by_*()
Date: Wed, 4 Dec 2024 21:42:12 +0100 [thread overview]
Message-ID: <20241204204227.95757-2-hdegoede@redhat.com> (raw)
In-Reply-To: <20241204204227.95757-1-hdegoede@redhat.com>
get_i2c_adap_by_handle() and get_i2c_adap_by_pci_parent() both are only
used by x86_instantiate_i2c_client() which is __init itself and in case
of the latter it also uses match_parent() which is also __init.
Fixes: 5b78e809f948 ("platform/x86: x86-android-tablets: Add support for getting i2c_adapter by PCI parent devname()")
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/x86-android-tablets/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c
index e9f4d91496d5..affaffadd179 100644
--- a/drivers/platform/x86/x86-android-tablets/core.c
+++ b/drivers/platform/x86/x86-android-tablets/core.c
@@ -157,7 +157,7 @@ static struct gpiod_lookup_table * const *gpiod_lookup_tables;
static const struct software_node *bat_swnode;
static void (*exit_handler)(void);
-static struct i2c_adapter *
+static __init struct i2c_adapter *
get_i2c_adap_by_handle(const struct x86_i2c_client_info *client_info)
{
acpi_handle handle;
@@ -177,7 +177,7 @@ static __init int match_parent(struct device *dev, const void *data)
return dev->parent == data;
}
-static struct i2c_adapter *
+static __init struct i2c_adapter *
get_i2c_adap_by_pci_parent(const struct x86_i2c_client_info *client_info)
{
struct i2c_adapter *adap = NULL;
--
2.47.0
next prev parent reply other threads:[~2024-12-04 20:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 20:42 [PATCH v3 0/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 Hans de Goede
2024-12-04 20:42 ` Hans de Goede [this message]
2024-12-04 20:42 ` [PATCH v3 2/8] platform/x86: x86-android-tablets: Make variables only used locally static Hans de Goede
2024-12-05 9:03 ` Andy Shevchenko
2024-12-08 14:16 ` Hans de Goede
2024-12-04 20:42 ` [PATCH v3 3/8] platform/x86: serdev_helpers: Check for serial_ctrl_uid == NULL Hans de Goede
2024-12-05 9:05 ` Andy Shevchenko
2024-12-05 10:32 ` Ilpo Järvinen
2024-12-05 14:11 ` Andy Shevchenko
2024-12-04 20:42 ` [PATCH v3 4/8] platform/x86: serdev_helpers: Add get_serdev_controller_from_parent() helper Hans de Goede
2024-12-04 20:42 ` [PATCH v3 5/8] platform/x86: x86-android-tablets: Change x86_instantiate_serdev() prototype Hans de Goede
2024-12-04 20:42 ` [PATCH v3 6/8] platform/x86: x86-android-tablets: Store serdev-controller ACPI HID + UID in a union Hans de Goede
2024-12-04 20:42 ` [PATCH v3 7/8] platform/x86: x86-android-tablets: Add support for getting serdev-controller by PCI parent Hans de Goede
2024-12-04 20:42 ` [PATCH v3 8/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 Hans de Goede
2024-12-10 14:03 ` [PATCH v3 0/8] " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204204227.95757-2-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox