From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 3/8] platform/x86: serdev_helpers: Check for serial_ctrl_uid == NULL
Date: Thu, 5 Dec 2024 11:05:38 +0200 [thread overview]
Message-ID: <Z1Fs4j8g7uC-Cc14@smile.fi.intel.com> (raw)
In-Reply-To: <20241204204227.95757-4-hdegoede@redhat.com>
On Wed, Dec 04, 2024 at 09:42:14PM +0100, Hans de Goede wrote:
> dell_uart_bl_pdev_probe() calls get_serdev_controller() with the
> serial_ctrl_uid parameter set to NULL.
>
> In case of errors this NULL parameter then gets passed to pr_err()
> as argument matching a "%s" conversion specification. This leads to
> compiler warnings when building with "make W=1".
>
> Check serial_ctrl_uid before passing it to pr_err() to avoid these.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
...
> + serial_ctrl_hid, serial_ctrl_uid ?: "*");
Not sure about '*' as it would mean 'any', perhaps 'none', '-', or 'undefined'
would be better, but since they are error messages, it's not so critical.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-05 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 20:42 [PATCH v3 0/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 Hans de Goede
2024-12-04 20:42 ` [PATCH v3 1/8] platform/x86: x86-android-tablets: Add missing __init to get_i2c_adap_by_*() Hans de Goede
2024-12-04 20:42 ` [PATCH v3 2/8] platform/x86: x86-android-tablets: Make variables only used locally static Hans de Goede
2024-12-05 9:03 ` Andy Shevchenko
2024-12-08 14:16 ` Hans de Goede
2024-12-04 20:42 ` [PATCH v3 3/8] platform/x86: serdev_helpers: Check for serial_ctrl_uid == NULL Hans de Goede
2024-12-05 9:05 ` Andy Shevchenko [this message]
2024-12-05 10:32 ` Ilpo Järvinen
2024-12-05 14:11 ` Andy Shevchenko
2024-12-04 20:42 ` [PATCH v3 4/8] platform/x86: serdev_helpers: Add get_serdev_controller_from_parent() helper Hans de Goede
2024-12-04 20:42 ` [PATCH v3 5/8] platform/x86: x86-android-tablets: Change x86_instantiate_serdev() prototype Hans de Goede
2024-12-04 20:42 ` [PATCH v3 6/8] platform/x86: x86-android-tablets: Store serdev-controller ACPI HID + UID in a union Hans de Goede
2024-12-04 20:42 ` [PATCH v3 7/8] platform/x86: x86-android-tablets: Add support for getting serdev-controller by PCI parent Hans de Goede
2024-12-04 20:42 ` [PATCH v3 8/8] platform/x86: x86-android-tablets: Add Bluetooth support for Vexia EDU ATLA 10 Hans de Goede
2024-12-10 14:03 ` [PATCH v3 0/8] " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1Fs4j8g7uC-Cc14@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox