X86 platform drivers
 help / color / mirror / Atom feed
* [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list
@ 2025-07-18 17:23 Mario Limonciello
  2025-07-21  8:15 ` Hans de Goede
  2025-07-22 14:40 ` Ilpo Järvinen
  0 siblings, 2 replies; 3+ messages in thread
From: Mario Limonciello @ 2025-07-18 17:23 UTC (permalink / raw)
  To: mario.limonciello, Shyam-sundar.S-k, hansg, ilpo.jarvinen
  Cc: Adam Berglund, platform-driver-x86

From: Mario Limonciello <mario.limonciello@amd.com>

The Lenovo Yoga 6 13ACL6 82ND has a similar BIOS problem as other Lenovo
laptops from that vintage that causes a rather long resume from suspend.

Add it to the quirk list that manipulates the scratch register to avoid
the issue.

Reported-by: Adam Berglund <adam.f.berglund@hotmail.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4434
Tested-by: Adam Berglund <adam.f.berglund@hotmail.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
index 131f10b683088..ded4c84f5ed14 100644
--- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
+++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
@@ -190,6 +190,15 @@ static const struct dmi_system_id fwbug_list[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "82XQ"),
 		}
 	},
+	/* https://gitlab.freedesktop.org/drm/amd/-/issues/4434 */
+	{
+		.ident = "Lenovo Yoga 6 13ALC6",
+		.driver_data = &quirk_s2idle_bug,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "82ND"),
+		}
+	},
 	/* https://gitlab.freedesktop.org/drm/amd/-/issues/2684 */
 	{
 		.ident = "HP Laptop 15s-eq2xxx",
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list
  2025-07-18 17:23 [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list Mario Limonciello
@ 2025-07-21  8:15 ` Hans de Goede
  2025-07-22 14:40 ` Ilpo Järvinen
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2025-07-21  8:15 UTC (permalink / raw)
  To: Mario Limonciello, mario.limonciello, Shyam-sundar.S-k,
	ilpo.jarvinen
  Cc: Adam Berglund, platform-driver-x86

Hi,

On 18-Jul-25 7:23 PM, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
> 
> The Lenovo Yoga 6 13ACL6 82ND has a similar BIOS problem as other Lenovo
> laptops from that vintage that causes a rather long resume from suspend.
> 
> Add it to the quirk list that manipulates the scratch register to avoid
> the issue.
> 
> Reported-by: Adam Berglund <adam.f.berglund@hotmail.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4434
> Tested-by: Adam Berglund <adam.f.berglund@hotmail.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@kernel.org>

Regards,

Hans




> ---
>  drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index 131f10b683088..ded4c84f5ed14 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -190,6 +190,15 @@ static const struct dmi_system_id fwbug_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "82XQ"),
>  		}
>  	},
> +	/* https://gitlab.freedesktop.org/drm/amd/-/issues/4434 */
> +	{
> +		.ident = "Lenovo Yoga 6 13ALC6",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82ND"),
> +		}
> +	},
>  	/* https://gitlab.freedesktop.org/drm/amd/-/issues/2684 */
>  	{
>  		.ident = "HP Laptop 15s-eq2xxx",


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list
  2025-07-18 17:23 [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list Mario Limonciello
  2025-07-21  8:15 ` Hans de Goede
@ 2025-07-22 14:40 ` Ilpo Järvinen
  1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2025-07-22 14:40 UTC (permalink / raw)
  To: mario.limonciello, Shyam-sundar.S-k, hansg, Mario Limonciello
  Cc: Adam Berglund, platform-driver-x86

On Fri, 18 Jul 2025 12:23:05 -0500, Mario Limonciello wrote:

> The Lenovo Yoga 6 13ACL6 82ND has a similar BIOS problem as other Lenovo
> laptops from that vintage that causes a rather long resume from suspend.
> 
> Add it to the quirk list that manipulates the scratch register to avoid
> the issue.
> 
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list
      commit: 4ff3aeb664f7dfe824ba91ffb0b203397a8d431e

--
 i.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-22 14:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-18 17:23 [PATCH] platform/x86/amd: pmc: Add Lenovo Yoga 6 13ALC6 to pmc quirk list Mario Limonciello
2025-07-21  8:15 ` Hans de Goede
2025-07-22 14:40 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox