* [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL
@ 2026-03-17 13:10 Sakari Ailus
2026-03-17 14:07 ` johannes.goede
2026-03-27 14:50 ` Dan Scally
0 siblings, 2 replies; 3+ messages in thread
From: Sakari Ailus @ 2026-03-17 13:10 UTC (permalink / raw)
To: linux-media
Cc: Antti Laakso, linux-gpio, platform-driver-x86, linusw, brgl,
sakari.ailus, mchehab, dan.scally, ilpo.jarvinen, hverkuil+cisco,
sre, hao.yao, jimmy.su, miguel.vadillo, kees, ribalda
A few fields in structs containing regulator initialisation data for Dell
laptops are initialised to 0 and NULL. Drop the explicit initialisation as
redundant.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
index 6bec5a910396..c1ddbf9a82c0 100644
--- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
+++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
@@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
.apply_uV = 1,
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
},
- .num_consumer_supplies = 0,
- .consumer_supplies = NULL,
};
static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
@@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
.apply_uV = 1,
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
},
- .num_consumer_supplies = 0,
- .consumer_supplies = NULL,
};
static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
@@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
.apply_uV = 1,
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
},
- .num_consumer_supplies = 0,
- .consumer_supplies = NULL,
};
static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
@@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
.apply_uV = 1,
.valid_ops_mask = REGULATOR_CHANGE_STATUS,
},
- .num_consumer_supplies = 0,
- .consumer_supplies = NULL,
};
static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
--
2.47.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL
2026-03-17 13:10 [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL Sakari Ailus
@ 2026-03-17 14:07 ` johannes.goede
2026-03-27 14:50 ` Dan Scally
1 sibling, 0 replies; 3+ messages in thread
From: johannes.goede @ 2026-03-17 14:07 UTC (permalink / raw)
To: Sakari Ailus, linux-media
Cc: Antti Laakso, linux-gpio, platform-driver-x86, linusw, brgl,
mchehab, dan.scally, ilpo.jarvinen, hverkuil+cisco, sre, hao.yao,
jimmy.su, miguel.vadillo, kees, ribalda
Hi,
On 17-Mar-26 14:10, Sakari Ailus wrote:
> A few fields in structs containing regulator initialisation data for Dell
> laptops are initialised to 0 and NULL. Drop the explicit initialisation as
> redundant.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> index 6bec5a910396..c1ddbf9a82c0 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> @@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> @@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> @@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> @@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL
2026-03-17 13:10 [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL Sakari Ailus
2026-03-17 14:07 ` johannes.goede
@ 2026-03-27 14:50 ` Dan Scally
1 sibling, 0 replies; 3+ messages in thread
From: Dan Scally @ 2026-03-27 14:50 UTC (permalink / raw)
To: Sakari Ailus, linux-media
Cc: Antti Laakso, linux-gpio, platform-driver-x86, linusw, brgl,
mchehab, ilpo.jarvinen, hverkuil+cisco, sre, hao.yao, jimmy.su,
miguel.vadillo, kees, ribalda
Hi Sakari
On 17/03/2026 13:10, Sakari Ailus wrote:
> A few fields in structs containing regulator initialisation data for Dell
> laptops are initialised to 0 and NULL. Drop the explicit initialisation as
> redundant.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> index 6bec5a910396..c1ddbf9a82c0 100644
> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
> @@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> @@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> @@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> @@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
> .apply_uV = 1,
> .valid_ops_mask = REGULATOR_CHANGE_STATUS,
> },
> - .num_consumer_supplies = 0,
> - .consumer_supplies = NULL,
> };
>
> static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 13:10 [PATCH 1/1] platform: int3472: Drop redundant initialisation to 0 and NULL Sakari Ailus
2026-03-17 14:07 ` johannes.goede
2026-03-27 14:50 ` Dan Scally
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox