From: "Ali Ahmet Memiş" <aliamemis@disroot.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Nitin Joshi" <nitjoshi@gmail.com>,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] platform/x86: thinkpad_acpi: convert conditional mutex locks to ACQUIRE_ERR()
Date: Sun, 6 Sep 2026 16:10:20 +0300 [thread overview]
Message-ID: <20260906131107.20966-2-aliamemis@disroot.org> (raw)
In-Reply-To: <20260806061925.625482-2-dmitry.torokhov@gmail.com>
Tested on a ThinkPad T490 with lockdep enabled, details in my reply to 1/3.
One question on brightness_get(). It is the backlight_ops->get_brightness
callback and has returned 0 on failure so far, with the conversion it now
returns a negative errno instead. In backlight.c that changes what callers
see. actual_brightness_show() passes the negative value out to the sysfs
read rather than reporting 0, and backlight_force_update() logs "Could not
update brightness from device" when the EC read fails. Is that intended?
I couldn't test this, since the T490 backlight is owned by i915, so
thinkpad-acpi registers no backlight device on this machine.
Tested-by: Ali Ahmet Memiş <aliamemis@disroot.org>
next prev parent reply other threads:[~2026-09-06 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 6:19 [PATCH 1/3] platform/x86: thinkpad_acpi: convert mutex_lock() to guard(mutex) Dmitry Torokhov
2026-08-06 6:19 ` [PATCH 2/3] platform/x86: thinkpad_acpi: convert conditional mutex locks to ACQUIRE_ERR() Dmitry Torokhov
2026-08-12 18:53 ` Mark Pearson
2026-09-06 13:10 ` Ali Ahmet Memiş [this message]
2026-08-06 6:19 ` [PATCH 3/3] platform/x86: thinkpad_acpi: use __free(kfree) for automatic cleanup Dmitry Torokhov
2026-08-12 19:02 ` Mark Pearson
2026-09-06 13:10 ` Ali Ahmet Memiş
2026-08-12 18:29 ` [PATCH 1/3] platform/x86: thinkpad_acpi: convert mutex_lock() to guard(mutex) Mark Pearson
2026-08-12 19:55 ` [ibm-acpi-devel] " Mark Pearson
2026-09-06 13:10 ` Ali Ahmet Memiş
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906131107.20966-2-aliamemis@disroot.org \
--to=aliamemis@disroot.org \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hansg@kernel.org \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=nitjoshi@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox