From: Hans de Goede <hdegoede@redhat.com>
To: "Pali Rohár" <pali@kernel.org>,
"Gerardo Esteban Malazdrewicz" <gerardo@malazdrewicz.com.ar>
Cc: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [ PATCH v2 1/1] dell smbios driver : Consider Alienware a valid OEM String
Date: Fri, 9 Oct 2020 11:14:33 +0200 [thread overview]
Message-ID: <209751e0-159c-9d10-91de-d77435e17c4a@redhat.com> (raw)
In-Reply-To: <20201009082658.mzzfqltg7xijm6fp@pali>
Hi,
On 10/9/20 10:26 AM, Pali Rohár wrote:
> On Friday 09 October 2020 02:33:49 Gerardo Esteban Malazdrewicz wrote:
>> dell-laptop doesn't even load as is ('No such device')
>>
>> However, adding an entry in dell_device_table, based on dmidecode
>> output (Vendor: Alienware, Type: 10), allows it to load.
>>
>> But I don't know how to test for any of this additional functionality.
>>
>> What should I look for?
>
> Hello! dell-laptop driver provides following features:
>
> * rfkill interface for enabling/disabling wifi and bluetooth
> - check presence of "*dell*" by /sbin/rfkill utility
>
> * backlight interface for controlling display brightness
> - check presence of "dell_backlight" in /sys/class/backlight/
>
> * touchpad led (if your touchpad has some led)
> - check presence of "dell-laptop::touchpad" in /sys/class/leds
>
> * configuring keyboard backlight
> - check presence of "dell::kbd_backlight" in /sys/class/leds
>
> * led for microphone mute
> - check presence of "platform::micmute" in /sys/class/leds
Thanks Pali, that is a great answer.
Note that the dell-wmi driver also depends on the
dell-smbios-base module, so you should also check if the
dell-wmi driver offers any additional functionality
on your laptop (if it does then that would also be a reason
to move forward with your dell-smbios-base patch).
Pali, can you perhaps make a similar feature list for
the dell-wmi driver ?
Regards,
Hans
next prev parent reply other threads:[~2020-10-09 9:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 11:52 [ PATCH: 1/1] dell smbios driver : Consider Alienware a valid OEM String Gerardo Esteban Malazdrewicz
2020-10-03 13:00 ` Hans de Goede
2020-10-05 12:45 ` Limonciello, Mario
2020-10-06 3:23 ` [ PATCH v2 " Gerardo Esteban Malazdrewicz
2020-10-07 14:21 ` Hans de Goede
2020-10-07 14:33 ` Pali Rohár
2020-10-07 15:53 ` Limonciello, Mario
2020-10-07 16:00 ` Hans de Goede
[not found] ` <45e82b6dabb591de630ac0e91a3ebb7937245fb1.camel@malazdrewicz.com.ar>
[not found] ` <DM6PR19MB26363563F46E95E50AD28854FA0A0@DM6PR19MB2636.namprd19.prod.outlook.com>
2020-10-07 20:38 ` Hans de Goede
2020-10-07 21:26 ` Limonciello, Mario
2020-10-07 21:30 ` Hans de Goede
2020-10-07 21:33 ` Limonciello, Mario
2020-10-09 5:33 ` Gerardo Esteban Malazdrewicz
2020-10-09 8:26 ` Pali Rohár
2020-10-09 9:14 ` Hans de Goede [this message]
2020-10-09 9:24 ` Pali Rohár
2020-10-09 9:40 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=209751e0-159c-9d10-91de-d77435e17c4a@redhat.com \
--to=hdegoede@redhat.com \
--cc=Mario.Limonciello@dell.com \
--cc=gerardo@malazdrewicz.com.ar \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox